833073 - gfxAndroidPlatform.cpp:31:0: warning: "LOG" redefined

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
../../../gfx/thebes/gfxAndroidPlatform.cpp:31:0: warning: "LOG" redefined [enabled by default]
../../../ipc/chromium/src/base/logging.h:95:0: note: this is the location of the previous definition
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=18994418&tree=Try

Conveniently, the LOG() macro defined in gfxAndroidPlatform.cpp is completely unused, so we can just drop it.

For historical context: this line was last touched as part of this cset for bug 623136:
https://hg.mozilla.org/mozilla-central/diff/ad6b7107bbe6/gfx/thebes/gfxAndroidPlatform.cpp#l1.46
...which included some LOG() invocations that have all since been removed.

(Alternately: if we really want to keep this unused LOG define for possible-future-use, let's just rename it so we don't clash with the other LOG() definition.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1: remove LOG() definition

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> Conveniently, the LOG() macro defined in gfxAndroidPlatform.cpp is
> completely unused, so we can just drop it.

Here's a MXR search to demonstrate this:
https://mxr.mozilla.org/mozilla-central/search?string=LOG&case=on&find=gfxAndroidPlatform.cpp

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 704657 [details] [diff] [review]
fix v1: remove LOG() definition

Review of attachment 704657 [details] [diff] [review]:
-----------------------------------------------------------------

This will change the label to the default one. Instead undef LOG prior to defining it.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 704657 [details] [diff] [review]
fix v1: remove LOG() definition

oh, you're quite right, its not used

Comment 5

[Daniel Holbert [:dholbert]]

Thanks! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e71faebd06ea

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/e71faebd06ea