gfxAndroidPlatform.cpp:31:0: warning: "LOG" redefined

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla21
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Build warning:
{
../../../gfx/thebes/gfxAndroidPlatform.cpp:31:0: warning: "LOG" redefined [enabled by default]
../../../ipc/chromium/src/base/logging.h:95:0: note: this is the location of the previous definition
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=18994418&tree=Try

Conveniently, the LOG() macro defined in gfxAndroidPlatform.cpp is completely unused, so we can just drop it.

For historical context: this line was last touched as part of this cset for bug 623136:
https://hg.mozilla.org/mozilla-central/diff/ad6b7107bbe6/gfx/thebes/gfxAndroidPlatform.cpp#l1.46
...which included some LOG() invocations that have all since been removed.

(Alternately: if we really want to keep this unused LOG define for possible-future-use, let's just rename it so we don't clash with the other LOG() definition.)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #704657 - Flags: review?(blassey.bugs)
(In reply to Daniel Holbert [:dholbert] from comment #0)
> Conveniently, the LOG() macro defined in gfxAndroidPlatform.cpp is
> completely unused, so we can just drop it.

Here's a MXR search to demonstrate this:
https://mxr.mozilla.org/mozilla-central/search?string=LOG&case=on&find=gfxAndroidPlatform.cpp
Comment on attachment 704657 [details] [diff] [review]
fix v1: remove LOG() definition

Review of attachment 704657 [details] [diff] [review]:
-----------------------------------------------------------------

This will change the label to the default one. Instead undef LOG prior to defining it.
Attachment #704657 - Flags: review?(blassey.bugs) → review-
Comment on attachment 704657 [details] [diff] [review]
fix v1: remove LOG() definition

oh, you're quite right, its not used
Attachment #704657 - Flags: review- → review+
https://hg.mozilla.org/mozilla-central/rev/e71faebd06ea
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.