833196 - Disable PGO on storage

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Comment 1

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/398af1ad9ea6

Comment 2

[Marco Bonardo [:mak]]

Storage has many consumers we care about perf, like the awesomebar, it's possible pgo on sqlite (provided we pgo C code) is enough, but no idea, off-hand I don't like much the idea to avoid optimizing something we always cared to keep performant.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

It's not like the compiler won't do optimization; it just won't be informed by runtime info.  Especially since well-behaved storage use should be I/O bound and on a background thread, storage/sqlite seems like a great place to take the hit in the name of faster JS/layout/XPConnect.

Comment 4

[(no longer active)]

Also, as I said elsewhere, the PGO profiling phase doesn't actually examine the awesomebar and the like, so I wouldn't be surprised if PGO doesn't actually optimize the code related to that much.

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/398af1ad9ea6