Disable PGO on storage

RESOLVED FIXED in mozilla21

Status

()

Toolkit
Storage
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

unspecified
mozilla21
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/398af1ad9ea6
Storage has many consumers we care about perf, like the awesomebar, it's possible pgo on sqlite (provided we pgo C code) is enough, but no idea, off-hand I don't like much the idea to avoid optimizing something we always cared to keep performant.

Updated

5 years ago
OS: Mac OS X → Windows 7
It's not like the compiler won't do optimization; it just won't be informed by runtime info.  Especially since well-behaved storage use should be I/O bound and on a background thread, storage/sqlite seems like a great place to take the hit in the name of faster JS/layout/XPConnect.
(Assignee)

Comment 4

5 years ago
Also, as I said elsewhere, the PGO profiling phase doesn't actually examine the awesomebar and the like, so I wouldn't be surprised if PGO doesn't actually optimize the code related to that much.
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/398af1ad9ea6
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.