Closed Bug 833196 Opened 8 years ago Closed 8 years ago

Disable PGO on storage

Categories

(Toolkit :: Storage, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

No description provided.
Storage has many consumers we care about perf, like the awesomebar, it's possible pgo on sqlite (provided we pgo C code) is enough, but no idea, off-hand I don't like much the idea to avoid optimizing something we always cared to keep performant.
OS: Mac OS X → Windows 7
It's not like the compiler won't do optimization; it just won't be informed by runtime info.  Especially since well-behaved storage use should be I/O bound and on a background thread, storage/sqlite seems like a great place to take the hit in the name of faster JS/layout/XPConnect.
Also, as I said elsewhere, the PGO profiling phase doesn't actually examine the awesomebar and the like, so I wouldn't be surprised if PGO doesn't actually optimize the code related to that much.
https://hg.mozilla.org/mozilla-central/rev/398af1ad9ea6
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.