[an] inc files broken for Aragonese due to malformed license headers

RESOLVED FIXED

Status

Mozilla Localizations
an / Aragonese
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Pike, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

5 years ago
The various defines.inc and bookmarks.inc files for your localization have a broken header, all the comments are in one line.

Dwayne said in bug 829246 comment 7 that this is likely due to an outdated version of translate toolkit, using Toolkit from master or the 1.10.0.RC1 release from http://translate.sourceforge.net/snapshots/ will solve this for you.

We can also create patches to fix the issue.

Both beta and aurora are affected

Comment 1

5 years ago
Still not fixed, please update the Translate Toolkit.  If you need any help with that please let me know.

Comment 2

4 years ago
Hi,

Daniel has fixed it in his personal repository:
https://hg.mozilla.org/users/entaltoaragon_gmail.com/an/
where he keeps translation up-to-date.

However, he comented me that he seems not to have permissions to upload it here:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/an

Can you help?

Thanks!
Created attachment 785519 [details] [diff] [review]
bug833341.patch

I think a good start would be the error he gets when he tries to commit, so that we can eventually involve IT.

From the history of that repository I see that Pascal has always been committing for him.

I tried to pull changes from his personal repository into mozilla-aurora, and there are two problems:
1. he removed the searchplugins folder (I kept the one currently on mozilla-aurora)
2. region.properties can't merge cleanly, I kept the one in this repository.

The patch with the changes is attached. It seems also to lose a lot of strings (reverting to English, see for example browser.properties).

Comment 4

4 years ago
Grazie Francesco,

Daniel has recently updated his repo. Can any of you take a look if we can move on? 

We would really love to have our first Aurora builds in Aragonese.

Wouldn't it be easier than Daniel had permission to mozilla-aurora l10n/an as well ? What would we need to do for making it possible?
I'm looking at his personal repository
https://hg.mozilla.org/users/entaltoaragon_gmail.com/an/rev/d2b47bd4bf88

Is this specific bug really fixed? I see that "#filter emptyLines" is now on a new line, but the license header still looks wrong.

See ca for a reference
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/file/a0d33038f732/browser/profile/bookmarks.inc

About the hg access, I see that it was requested in bug 741305, I'll ask Pike about that.

Comment 6

4 years ago
(In reply to Francesco Lodolo [:flod] from comment #5)
> I'm looking at his personal repository
> https://hg.mozilla.org/users/entaltoaragon_gmail.com/an/rev/d2b47bd4bf88
> 
> Is this specific bug really fixed? I see that "#filter emptyLines" is now on
> a new line, but the license header still looks wrong.
> 
> See ca for a reference
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/file/a0d33038f732/
> browser/profile/bookmarks.inc
> 

Problem with inc should be fixed at server side. Strings are actually generated in the same server for an and ca. Daniel, can you overwrite all involved .inc?

> About the hg access, I see that it was requested in bug 741305, I'll ask
> Pike about that.

Cool, thanks!

Comment 7

4 years ago
It should be fixed now at my user repo, (.inc files updated)
(Reporter)

Comment 8

4 years ago
Looks good. Daniel, can you pull from the upstream repo and merge? There are quite a few heads on your user repo, and we'll want to get you in sync with what happens upstream.

If that's tricky, Pascal or I should be able to help. We can also push to your clone, so once a merge is done, we'd just push to that, and you pull and update.

Comment 9

4 years ago
I tried to do what you are asking for, can you check if it is done?
(Reporter)

Comment 10

4 years ago
Pascal has been doing most of the hg upstreaming work. Pascal, can you take a look?

Also, https://l10n.mozilla.org/teams/an looks like there's more than just the product l10 to drive forward?
Something is wrong with the searchplugins: eBay-es.xml and yahoo-es.xml are not in list.txt anymore.

They used to be there after bug 800415 landed, so you need to fix that.
https://hg.mozilla.org/users/entaltoaragon_gmail.com/an/rev/0a259ff7e0d8
I pushed changes to http://hg.mozilla.org/releases/l10n/mozilla-aurora/an with a couple of more changesets.

Restored correct list.txt
http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/9086f31d1fef

Removed some extra lines from .inc files to make them more readable (no changes to content)
http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/fac71de4d9ea
Attachment #785519 - Attachment is obsolete: true
Fixed missing ending new lines in
http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/16ff88918ca6

This bug is fixed, but you currently have 2 errors and some missing files to check
https://l10n.mozilla.org/dashboard/compare?run=340942
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 14

4 years ago
Daniel, make sure to pull from the aurora repo again? Thanks.

Comment 15

4 years ago
Now it's done. Thanks.
You need to log in before you can comment on or make changes to this bug.