83336 - Crash trying to view contents of local directory file:///c|\

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[bmartin]

Latest mfcembed dated: 05-30-01

O/S: Win98
System: Dell Latitude CPi 400MHz 128MB RAM

Steps:
1. Download latest embed-win32.zip and extract file
2. Launch mfcembed.exe
3. Enter file:///c|/ in the URL text field to view contents of the directory

Results:
mfcembed caused invalid page fault in module xpcom.dll at 015f:60e9a870
select close
mfcembed caused invalid page fault in module mfc42.dll

Comment 1

[Adam Lock]

*** Bug 85969 has been marked as a duplicate of this bug. ***

Comment 2

[Adam Lock]

Crash is occurring in nsStreamConverterService. Probably the converter that 
turns a directory listing into HTML/RDF is missing.

Checking further.

Comment 3

[Adam Lock]

Crash is triggered by missing http-index-format stream converter 
object implemented by mozilla/xpfe/components/directory and part of 
appcomps.dll. This causes a null pointer to be passed into a hash table lookup 
which then crashes.

Patch follows to insert pointer check. Getting directory viewer to actually 
work in embedding is more involved because of how the viewer is packaged and 
some issues with the chrome.

Comment 4

[Adam Lock]

Attachment: Review please. 1 line patch to check for null pointer

Comment 5

[rpotts (gone)]

r=rpotts

Comment 6

[Darin Fisher]

sr=darin (i think i filed a dupe of this a while back... probably assigned it to
valeski).  we'll hit this anytime someone asks for a stream converter that doesn't
exist.

Comment 7

[Adam Lock]

Fix is checked in (to trunk)

Comment 8

[Michael Dunn]

Clean up verification of dated code change bus