833366 - [Settings :: App Permissions] incorrect style for “Uninstall app” buttons & dialogs

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Fabien Cazenave [:kaze]]

Attachment: screenshot

See attachment:

 • in the Settings panel, the “Uninstall app” button should be the one we use for all dialog boxes: gray background + little triangle in the bottom-right corner;

 • in the dialog box, the “Clear” button should carry the `.danger' class to have the proper red background.

This will also apply to the “Clear bookmark data” button & dialog when bug 829397 lands.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for UX branch

I fixed the first part of the bug, but I need help for the dialog. Kaze, can you help me with this one?

Comment 2

[Fabien Cazenave [:kaze]]

Ugh, I realize the OK/Cancel dialog is a JS `prompt()', that’s why the “OK” button can’t be styled. We should either use a custom dialog in HTML instead, or keep a red button… :-/

Concerning the <select> boxes for allow/deny is not part of this bug but it’s certainly a nice improvement. I remember Patryk has opened a bug about those drop-down lists a while ago… but I couldn’t find it.

Comment 3

[Sam Joch [:samjoch]]

Pavel,

I think you should PR this one in master directly (to many js here);

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I will finish patch these days and do a PR to master. Thanks :)

Comment 6

[Fabien Cazenave [:kaze]]

Comment on attachment 705519 [details]
patch for UX branch

This went off my radar… However, I’ve found other similar cases where the main button is red and the UX team doesn’t complain about that, so I’m closing this bug as INVALID.