833383 - "based on mozilla technology" should be aligned with the text on the left

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Julien Wajsberg [:julienw]]

Attachment: screenshot

This is in FTU's "B2G OS Privacy Choices" page.

see screenshot

Comment 1

[Sam Joch [:samjoch]]

Attachment: Before / After Screenshots

Comment 2

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #1)
> Created attachment 728950 [details]
> Before / After Screenshots

Looks good, Thanks Sam!

Comment 3

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/55f3054f90397251d4310e3d3f7f050dace2a020

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: empty patch to request an approval for

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: bad UX feeling
Testing completed: yes
Risk to taking this patch (and alternatives if risky): none, only an image is changed by another image, there is no code change at all. And it is in the "unofficial" branding directory so I guess it will never be on production devices anyway.
String or UUID changes made by this patch: none

Comment 5

[Julien Wajsberg [:julienw]]

Sam, have you checked if the official branding looked good too ?

Comment 6

[Sam Joch [:samjoch]]

actually i have only changed the margin inside the image so the official branding is not affected.

Comment 7

[Julien Wajsberg [:julienw]]

Yep I know you didn't changed the officiel branding yet, but I mean, have you checked that the current officiel branding looks ok ? :-)

Comment 8

[Sam Joch [:samjoch]]

Ok i see, the official branding logo is centered and bigger than the unofficial one, i checked that yes.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 730650 [details] [diff] [review]
empty patch to request an approval for

a=npotb i believe

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 55f3054f90397251d4310e3d3f7f050dace2a020
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 11

[Julien Wajsberg [:julienw]]

v1-train: 0dfdc76c783fa9e03a4d7256f115472c4a1e33e4

The conflict was due to Bug 830644 which is not uplifted. I added a comment in the commit log to warn if Bug 830644 is uplifted at one point.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

v1 train gaia : commit 23576fd2977a36750e5742af3ac9b038d1bcc588
master : gaia : commit 3b7fb2faf6fd7c4fb1ff568f7978e56fda1f6061