Send RP ID within mozChromeEvents

RESOLVED FIXED in Firefox 21

Status

()

Core
Identity
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ferjm, Assigned: ferjm)

Tracking

unspecified
mozilla21
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is the identity counterpart of Bug 832951.

More info at https://bugzilla.mozilla.org/show_bug.cgi?id=832948#c0
(Assignee)

Updated

5 years ago
Assignee: nobody → ferjmoreno
Blocks: 832948
blocking-b2g: --- → tef?
(Assignee)

Comment 1

5 years ago
Created attachment 704964 [details] [diff] [review]
v1
Attachment #704964 - Flags: review?(jparsons)
(Assignee)

Comment 2

5 years ago
Comment on attachment 704964 [details] [diff] [review]
v1

Review of attachment 704964 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/SignInToWebsite.jsm
@@ +180,5 @@
>        let detail = {
>          type: kReceivedIdentityAssertion,
>          showUI: aGaiaOptions.showUI || false,
> +        id: kReceivedIdentityAssertion + "-" + uuid,
> +        requestId: aRpOptions.id 

oops, white space, I'll remove it from the final version.
Comment on attachment 704964 [details] [diff] [review]
v1

r=me!  And the corresponding gaia patch is lovely.  As soon as this lands, we can go ahead and merge that.

Thanks for your work on this,
j
Attachment #704964 - Flags: review?(jparsons) → review+
Triage is a bit puzzled on this one. Can this actually reproduce with our v1 requirements? We only have one payment flow for v1.

How would I reproduce this with our existing v1 constraints? Can you explain a bit more?
Flags: needinfo?(ferjmoreno)
(Assignee)

Comment 5

5 years ago
This bug is a dependency for bug 832948 so the same reply at https://bugzilla.mozilla.org/show_bug.cgi?id=832948#c8 applies here.
Flags: needinfo?(ferjmoreno)
(Assignee)

Comment 6

5 years ago
Thanks Jed!

https://hg.mozilla.org/integration/mozilla-inbound/rev/61f5684286e6
blocking-b2g: tef? → tef+
I see the counterpart bug 832951 has already landed in b2g18.  Do we need to set any additional flags on this for it to get the same treatment?
Keywords: checkin-needed
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/releases/mozilla-b2g18/rev/491dd35f1ca8
Keywords: checkin-needed
status-b2g18: --- → fixed
status-firefox19: --- → wontfix
status-firefox20: --- → wontfix
status-firefox21: --- → fixed
Target Milestone: --- → mozilla21
https://hg.mozilla.org/mozilla-central/rev/61f5684286e6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Whiteboard: [qa-]
Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.
status-b2g18-v1.0.0: --- → fixed
You need to log in before you can comment on or make changes to this bug.