Closed Bug 833512 Opened 11 years ago Closed 11 years ago

Flag instances of null passed in place of a privacy context

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Validation
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kmag, Assigned: kmag)

References

Details

(Whiteboard: [ReviewTeam:P1]) 

Several interfaces were changed, as of Gecko 18, to require a privacy context for per-window PBM support. While null can be passed where no privacy context is appropriate, doing so is almost always the Wrong Thing. We need to flag when null is passed in these arguments. See dependent bugs for interface details.
I've had to prelim dozens of add-ons for this in the past few days, and the ones not being reviewed by me are probably passing without notice. This needs to happen ASAP.
Severity: normal → major
Whiteboard: [ReviewTeam:P1]
https://github.com/mozilla/amo-validator/pull/195
Assignee: nobody → kmaglione+bmo
That PR was merged
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.