83352 - Entering incorrect password for proxy authentication causes endless loop

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[Bradley Baetz (:bbaetz)]

Set your proxy settings to tegu.mozilla.org:3130 (56K bandwidth limiting proxy).
If you log in with an incorrect username/password prompt, then no matter what
you enter at the next prompt, the browser goes into an endless GET/407 loop with
the proxy server.

From a network trace, we appear to be appending to the proxy-authentication
header, so that we send:

Proxy-Authorization: Basic Foo

then, the next packet

Proxy-Authorization: Basic Foo, Basic Foo

then

Proxy-Authorization: Basic Foo, Basic Foo, Basic Foo

and so on.

By the time we get to the 1000'th odd exchange we take about 10 packets just to
send the headers.

Checked on 8am mozilla bits.

Comment 1

[Darin Fisher]

Attachment: fixes the problem

Comment 2

[Darin Fisher]

bbaetz: can you test and r= this patch?  thx!

Comment 3

[Doug Turner (:dougt)]

rs=dougt

Comment 4

[Bradley Baetz (:bbaetz)]

r=bbaetz

Comment 5

[Darin Fisher]

fix checked in

Comment 6

[Bradley Baetz (:bbaetz)]

VERIFIED on branch 2001060713 linux build. Leaving as resolved until the other
platforms are checked.

Comment 7

[benc]

VERIFIED:
99% sure I hit this while doing nsbeta1 functionals.