833526 - Not be able to receive "network-active-change" notification from NetworkManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Stephen Li]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130116073211

Steps to reproduce:

trying to listen to “network-active-change” observer notification


Actual results:

“network-active-change” is never getting notified to the observer when switch between WiFi and cellular data network.


Expected results:

Should get “network-active-change” observer notification. Changes below work for us:

+      if(this.active != oldActive) {
+        Services.obs.notifyObservers(this.active, "network-active-changed", null);
+      }

Add the above 3 lines to be above the line 383 and line 421 below,

http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkManager.js#383
http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkManager.js#421

Comment 1

[Shian-Yow Wu [:swu]]

Attachment: Patch V1: Add network-active-changed notification

Hi Stephen,

Thanks for reporting this issue.  Please check if this patch works for you.

Comment 2

[Shian-Yow Wu [:swu]]

Attachment: Patch V2

Only notify when active network really changed.

Comment 3

[Shian-Yow Wu [:swu]]

Hi Stephen,

We are waiting for your feedback before landing this patch.  Do you have any update?  Thanks.

Comment 4

[Shian-Yow Wu [:swu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c929bc0ee9a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c929bc0ee9a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/fe99594f53eb

Comment 7

[Stephen Li]

https://bugzilla.mozilla.org/show_bug.cgi?id=833526 : Yes this change looks fine to me, can we get it integrated.

Comment 8

[Michael Vines [:m1] [:evilmachines]]

(I'll work with Stephen on this)