Closed Bug 83354 Opened 24 years ago Closed 3 years ago

pasting performance has degraded - HTMLEditor::HandleInsertText() needs to be unified with WSRunObject::InsertText() and WSRunObject::InsertBreak().

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: sujay, Unassigned)

References

(
URL
)

Details

(Keywords: perf, regression)

pasting has gotten slower in recent builds... see URL above which shows paste performance data.
Keywords: perf
Priority: -- → P3
Whiteboard: [perf]
Target Milestone: --- → mozilla1.0
The URL doesn´t work....
the URL will work tomorrow....its on the staging area right now... give it 18 hours.
What needs to happen here is the logic in nsHTMLEditRules::WillInsertText() needs to be unfied with the underlying logic in nsWSRunObject::InsertText() and nsWSRunObject::InsertBreak(). We need to move over to the string sink that Scott added to nsWriteableString, and try to do everything in one pass. It's pretty tricky but should be doable.
Status: NEW → ASSIGNED
Sujay, can you add another set of paste data to your table with a recent build?
sure Joe...I'll get you some data with recent build soon...stay tuned.
Joe, I just pushed up the latest paste performance data: http://people.netscape.com/sujay/composer_perf.html If you check it today(9/13) you may not see it. give it a day to be pushed from staging server area.
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
removing myself from the cc list
The trunk is the wave of the future!
Target Milestone: mozilla1.0.1 → mozilla1.1beta
The days of having a half dozen milestones out in front of us to divide bugs between seem to be gone, though I dont know why. Lumping everything together as far out as I can. I'll pull back things that I am working on as I go.
Target Milestone: mozilla1.1beta → mozilla1.2beta
migrating milestones now that there are more available. i'll pull these back as I work on them
Target Milestone: mozilla1.2beta → mozilla1.4beta
QA Contact: sujay → editor
Assignee: mozeditor → nobody
Status: ASSIGNED → NEW
URL: http://people.netscape.com/sujay/comp... → NA http://people.netscape.com/sujay/c...
Keywords: regression
Summary: pasting performance has degraded → pasting performance has degraded - nsHTMLEditRules::WillInsertText() needs to be unified with nsWSRunObject::InsertText() and nsWSRunObject::InsertBreak().
Whiteboard: [perf]
Target Milestone: mozilla1.4beta → ---
Type: defect → enhancement
Summary: pasting performance has degraded - nsHTMLEditRules::WillInsertText() needs to be unified with nsWSRunObject::InsertText() and nsWSRunObject::InsertBreak(). → pasting performance has degraded - HTMLEditor::HandleInsertText() needs to be unified with WSRunObject::InsertText() and WSRunObject::InsertBreak().
Type: enhancement → defect

Page no longer active

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.