833552 - Tapping "+" on Compose Screen Briefly Shows Keyboard

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[David Walsh :davidwalsh]

Tapping the "+" text in the "to" line of new email composition briefly shows the keyboard before bringing up the contact screen;  we should avoid showing the keyboard at all.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

This is a sort-of expected outcome from the landing of bug 812534 in which we greatly enlarged the region where clicking will focus the input box.  What will happen now is we will trigger the contact-picker activity, but then the 'click' event will also bubble to focus the input.

Probably the best/easiest solution is to have onContactAdd call stopPropagation() and then *maybe* force the input field to be focused when we return.  The keyboard showing up can be fairly annoying, so we might be better off not triggering the keyboard at all...

Casey, what should we do?  Also, can we get that codified into the interaction diagrams since focus has turned out to be a pretty important thing for these fields?

Comment 2

[Casey Yee]

I know it's usually easier said than done but:
Could we not have it so that the To input field doesn't overlap the "+"?   This way the user wouldn't inadvertently focus the input field causing the keyboard to pop-up?

Ideally we also have the subject field focused with the keyboard up when you return back so you can directly start entering a subject.

Agree on adding this to the IxD.  I will work on doing that.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

The input field doesn't overlap the "+".  We added a "click" listener to a div that contains most of the line to transfer focus to that input, so it's a question of how the DOM is arranged and how we want the clicks caught.  Click-wise, I presume we probably want a clear horizontal split.  DOM-wise, I think we were trying to avoid causing visual regressions, and I think we would stick with that on any branches where we are supposed to be conservative with changes.

Comment 4

[Kevin Grandon :kgrandon]

Oops, looks like I definitely caused this one! Would tend to agree with Andrew that the best fix for now would be stopPropagation().

I think auto-focusing the subject line might cause usability issues when trying to send a mail to more than one recipient. That should probably be tracked in a different bug.

Andrew - Being this bug's father, I will assign to myself and create a pull request for you to review. Unless you really want to take it?

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

fix away!

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Simple polish change which makes it so the keyboard does not show when we add a contact to email.

Also requesting approval for v1 so we can land on v1-train. Thanks!

Comment 7

[Kevin Grandon :kgrandon]

This is now landed in master, thanks for the quick review.

If we get v1 approval I'll cherry-pick it into v1-train.

https://github.com/mozilla-b2g/gaia/commit/28944fcd761bf54a296d1da3f54f49cab87de00d

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 705158 [details]
Github pull request pointer

approved for the v1-train, i.e. for the v1.0.1 release.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Kevin Grandon from comment #7)

> If we get v1 approval I'll cherry-pick it into v1-train.

Beat you to it :)

v1-train: 1b16d870660dd6cb0388679cd93c1438672f2bed