833622 - Bubble up proxy errors nicely

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Launch marketplace-dev app on your unagi phone
2. Log in using Identity
3. Click on the purchase button for 'Private Yacht'

observed behavior:
'Something went wrong' screen is shown

traceback details:
HttpServerError: Server Error 500: https://payments-dev.allizom.org/bango/billing/ Content: {"error_code": "AttributeError", "error_data": {}, "error_message": "'NoneType' object has no attribute 'responseCode'"} : JSON: {u'error_data': {}, u'error_code': u'AttributeError', u'error_message': u"'NoneType' object has no attribute 'responseCode'"}

sentry: http://sentry.dmz.phx1.mozilla.com/marketplace-dev-webpay/group/10984/

Comment 1

[Andy McKay]

This was fixed yesterday, it was due to solitude deployment issues. It's not urgent but the handling of the 500 in a nicer manner is something I'd like to fix.

Comment 2

[Wil Clouser [:clouserw]]

This has been bumped a lot.  What's the status?

Comment 3

[Wraithan (Chris McDonald) [:wraithan]]

I am working on this today, I haven't done much with the interaction between solitude and solitude-proxy, and may need to bubble all the way to webpay depending on what we want, so it is a bit involved.

Comment 4

[Kumar McMillan [:kumar]]

This critical, we need to fix this ASAP. bug 864672 was really hard to track down.

Comment 5

[Andy McKay]

https://github.com/mozilla/solitude/commit/d25161

You will get two log messages: one on the proxy and then on the client. Then there's a list of errors that are fatal from the proxy. Currently a 500 from the proxy is the only error. But its now a proxy error, not a SUDS processing error.