Closed Bug 833627 Opened 7 years ago Closed 7 years ago

Reject gcc < 4.4

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

We're already rejecting all versions of gcc on mac (which, effectively, is gcc 4.2), and are assuming gcc >= 4.4 in some places (see bug 822717). IIRC, even without these explicit assumptions, some code no longer even builds with gcc < 4.4.
I approve this message.
Assignee: nobody → mh+mozilla
Comment on attachment 705178 [details] [diff] [review]
Reject gcc < 4.4, and remove a few unused Xcode related variables

Review of attachment 705178 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +402,5 @@
>  
> +if test -n "$GNU_CC" -a -z "$CLANG_CC" ; then
> +    if test "$GCC_MAJOR_VERSION" -eq 4 -a "$GCC_MINOR_VERSION" -lt 4 ||
> +       test "$GCC_MAJOR_VERSION" -lt 4; then
> +        AC_MSG_ERROR([Only gcc >= 4.4 is supported])

I would probably word this more in English, "Only GCC 4.5 or newer is supported."

::: js/src/configure.in
@@ +681,5 @@
>  if test "$COMPILE_ENVIRONMENT"; then
>  
>  dnl ========================================================
>  dnl = Mac OS X toolchain support
>  dnl ========================================================

Are you not adding the same GCC version check to the JS configure?
Attachment #705178 - Flags: review?(ted) → review+
Oops, the error text change in main configure.in wasn't committed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9f778ff6697
https://hg.mozilla.org/mozilla-central/rev/17661fe24da1
https://hg.mozilla.org/mozilla-central/rev/b9f778ff6697
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Depends on: 834429
Heads-up: I think the $GCC_MAJOR_VERSION and $GCC_MINOR_VERSION variables aren't necessarily set, at the time that we're checking them -- see bug 836161.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.