Closed Bug 833629 Opened 12 years ago Closed 12 years ago

Rebucket memory telemetry

Categories

(Toolkit :: Telemetry, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: justin.lebar+bug, Unassigned)

Details

Attachments

(1 file)

1GB is the largest RSS bucket, and about 13% of users have RSS over 1GB. We have a similar but less acute problem with explicit and the other memory reporters. I don't suggest this lightly (because it messes up our ability to compare current performance to the past), but I think we need to rebucket these histograms.
I assume you want to rebucket because you want that single 1GB+ bucket to be more fine-grained? What do you see as the benefit of this finer bucketing? (And ancillary effects on smaller buckets.)
> What do you see as the benefit of this finer bucketing? If we make a change which takes someone from using 2gb to 1.1gb of RAM (or vice versa!), it won't show up in telemetry. > (And ancillary effects on smaller buckets.) I'm planning to add many more buckets at the same time, so we'll get more insight into the smaller buckets, not less.
Attached patch Patch, v1Splinter Review
I went through each of the memory-related histograms. For those with a significant number hitting the right edge of the histogram, I made the histogram much wider (to 16GB) and much higher resolution (200 buckets). Hopefully this will keep us from having to rebucket again.
Attachment #705174 - Flags: review?(n.nethercote)
Attachment #705174 - Flags: review?(n.nethercote) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: