833659 - REINSTALL_FORBIDDEN error isn't triggering when installing a packaged app with a mini-manifest off of X origin when a hosted app was already installed from X origin

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Jason Smith [:jsmith]]

Build: B2G 18 1/22/2013
Device: Unagi

Steps:

1. Go to http://mozqa.com/webapi-permissions-tests/
2. Install "Hosted App Test Case 1"
3. Install "Packaged App Test Case 2"

Expected:

App install after step #3 should fail with REINSTALL_FORBIDDEN.

Actual:

App install is successful. This is problematic because when you try uninstall both apps, the packaged app will uninstall, but the hosted app will not uninstall until the phone is restarted (i.e. icon is left behind). Likely due to the single app per origin constraint.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch

Comment 2

[Julien Wajsberg [:julienw]]

I would have fixed gaia instead for this, but well.

Comment 3

[[:fabrice] Fabrice Desré]

Doing gaia workarounds for issues that lead to something corrupted in the backend is not a good idea, and gaia is not the only userr of this api.

Comment 4

[Julien Wajsberg [:julienw]]

In this specific case, the backend is not corrupted... since the reboot fixes this.

This is really the homescreen not handling correctly the uninstall.

But it's maybe easier to just disable this in gecko for now.

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 705258 [details] [diff] [review]
patch

[Approval Request Comment]
This is part of a set of patches that helps hardening against edge cases that may let the phone in a bad state. Risk is low compared to the reward.

Comment 6

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de3a78d90afa

Comment 7

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/63f6c3b4930a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/de3a78d90afa