Closed Bug 833668 Opened 11 years ago Closed 11 years ago

Fix all jstests that break with --disable-e4x

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 833208

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

(Whiteboard: [js:t]) 

Lots of jstests fail when the shell is built with --disable-e4x.  They need to be fixed -- either the test should be removed, or the e4x part(s) should be removed.
There are three classes of e4x-failing tests.

1. Ones specifically testing e4x spec stuff.  E.g. e4x/XML/13.4.4.3.js.  I
   propose that we remove all of these ones.

2. Regression tests under e4x, e.g. e4x/Namespace/regress-283972.js and
   e4x/Regress/regress-372564.js.  It looks like a lot of these will be
   completely gutted if we remove the e4x parts, and so can be removed.  But
   I'm happy to go through them individually and save any that have significant
   non-e4x parts.  (I.e. treat them like I did the jit-tests.)

3. Others, e.g. js1_7/block/regress-352267.js, e4x/GC/regress-339785.js.  I
   plan to also treat these like the jit-tests.

Sound reasonable?
Actually, I'll just do this in 833208.
No longer blocks: 788293
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.