[COST CONTROL] No error is shown when you try to topup with an incorrect topup code

RESOLVED FIXED

Status

Firefox OS
Gaia::Cost Control
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: carlosmartinez, Assigned: salva)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 fixed)

Details

(Whiteboard: QARegressExclude)

Attachments

(1 attachment)

Tested in unagi with Gecko-6a506d1 Gaia-1890022.

STR:
1-Pull down notification tray with a prepaid VIVO SIM inserted on the device
2-Tap in topup with code
3-Introduce a number (e.g. "12345678901234")
4-Press send

Expected result --> Some kind of error message (e.g. "Incorrect topup code entered")

Actual result --> No error is shown
Blocking because this is a showcase feature for the target markets, and a HUGE annoyance for daily use when topping-up. This is exactly the kind of scenario that turns a delight feature into a papercut.
blocking-b2g: tef? → tef+

Updated

5 years ago
Assignee: nobody → salva
Created attachment 705870 [details]
Adding a desktop notification when receiving a top up error
Attachment #705870 - Flags: review?(francisco.jordano)
Comment on attachment 705870 [details]
Adding a desktop notification when receiving a top up error

Code looking well, tried on the phone with a prepaid vivo sim and fix the bug ;)

Good job Salva, adding :stas for review as we are modifying some strings.
Attachment #705870 - Flags: review?(stas)
Attachment #705870 - Flags: review?(francisco.jordano)
Attachment #705870 - Flags: review+
Comment on attachment 705870 [details]
Adding a desktop notification when receiving a top up error

r=me.
Attachment #705870 - Flags: review?(stas) → review+
Landed on master:
https://github.com/mozilla-b2g/gaia/commit/b978ccaf2bd55ff0ce20082dd378069132b6eb29
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
status-b2g18: --- → fixed
John can you confirm that this was uplifted to both v1-train and v1.0.0 branches?  Now that we have the new status-b2g18-v1.0.0 flag we can distinguish between the two when marking. See https://wiki.mozilla.org/B2G/Triage#Flag_Descriptions
status-b2g18-v1.0.0: --- → affected
Yes, it's on v1.0.0

https://github.com/mozilla-b2g/gaia/commit/a7fcd500de29e2af290f752f5ac6bed9a9c376ee

Thank you for adding this new flag!
status-b2g18-v1.0.0: affected → fixed

Updated

5 years ago
Whiteboard: QARegressExclude

Comment 8

5 years ago
No need to create a TC in Moztrap for this defect.
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.