833780 - [COST CONTROL] No error is shown when you try to topup with an incorrect topup code

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested in unagi with Gecko-6a506d1 Gaia-1890022.

STR:
1-Pull down notification tray with a prepaid VIVO SIM inserted on the device
2-Tap in topup with code
3-Introduce a number (e.g. "12345678901234")
4-Press send

Expected result --> Some kind of error message (e.g. "Incorrect topup code entered")

Actual result --> No error is shown

Comment 1

[Dietrich Ayala (:dietrich)]

Blocking because this is a showcase feature for the target markets, and a HUGE annoyance for daily use when topping-up. This is exactly the kind of scenario that turns a delight feature into a papercut.

Comment 2

[Salvador de la Puente González [:salva]]

Attachment: Adding a desktop notification when receiving a top up error

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 705870 [details]
Adding a desktop notification when receiving a top up error

Code looking well, tried on the phone with a prepaid vivo sim and fix the bug ;)

Good job Salva, adding :stas for review as we are modifying some strings.

Comment 4

[Staś Małolepszy :stas]

Comment on attachment 705870 [details]
Adding a desktop notification when receiving a top up error

r=me.

Comment 5

[Salvador de la Puente González [:salva]]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/b978ccaf2bd55ff0ce20082dd378069132b6eb29

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

John can you confirm that this was uplifted to both v1-train and v1.0.0 branches?  Now that we have the new status-b2g18-v1.0.0 flag we can distinguish between the two when marking. See https://wiki.mozilla.org/B2G/Triage#Flag_Descriptions

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Yes, it's on v1.0.0

https://github.com/mozilla-b2g/gaia/commit/a7fcd500de29e2af290f752f5ac6bed9a9c376ee

Thank you for adding this new flag!

Comment 8

[amiller]

No need to create a TC in Moztrap for this defect.