Closed Bug 833784 Opened 11 years ago Closed 11 years ago

[COST CONTROL] No notification is shown in notification tray when 0 balance is reached or low limit is surpassed

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Cost Control
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:tef+, b2g18+ fixed, b2g18-v1.0.0 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
b2g18 + fixed
b2g18-v1.0.0 --- fixed

People

(Reporter: carlosmartinez, Assigned: salva)

References

Details

(Whiteboard: interaction, UX-P1, TEF_REQ, QARegressExclude)

Attachments

(1 file)

Adding desktop notifications when surpassing the limit for balance and reaching zero credit
250 bytes, text/html
arcturus
: review+
lsblakk
: approval-gaia-v1+
Details 
Tested in unagi with Gecko-6a506d1 Gaia-1890022.

STR:
1-Pull down notification tray
2-Verify that balance is close to 0
3-Send a SMS
4-Pull down notification tray

Expected result --> A notification in the notification tray is shown saying: "Balance has reached zero, no phone credit remaining."

Actual result --> No notification is shown
blocking-b2g: tef? → -
tracking-b2g18: --- → +
Whiteboard: interaction, UX-P1
Assignee: nobody → salva
This bug is closely related with #833782. As both have the tracking-b2g18+ flag, I'm going to reword this to include that and mark the other one as duplicated.
Summary: [COST CONTROL] No notification is shown in notification tray when 0 balance is reached → [COST CONTROL] No notification is shown in notification tray when 0 balance is reached or low limit is surpassed
[Approval Request Comment]
Bug caused by (feature/regressing bug #): this one
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low
Attachment #707617 - Flags: review?(francisco.jordano)
Attachment #707617 - Flags: approval-gaia-v1?(francisco.jordano)
Comment on attachment 707617 [details]
Adding desktop notifications when surpassing the limit for balance and reaching zero credit

We are not localizing debug stuff so cancelling the l10n review.
Attachment #707617 - Flags: review?(stas)
Comment on attachment 707617 [details]
Adding desktop notifications when surpassing the limit for balance and reaching zero credit

Hope all is ok now ;)
Comment on attachment 707617 [details]
Adding desktop notifications when surpassing the limit for balance and reaching zero credit

Thanks Salva :)
Attachment #707617 - Flags: review?(francisco.jordano) → review+
Comment on attachment 707617 [details]
Adding desktop notifications when surpassing the limit for balance and reaching zero credit

No sign of l10n changes, this looks to just display the notification at the correct times, so approving for uplift to v1-train and v1.0.0
Attachment #707617 - Flags: approval-gaia-v1?(francisco.jordano) → approval-gaia-v1+
Landed on master:
https://github.com/mozilla-b2g/gaia/commit/acf520ddf6735f60177697f84f39dc393e013b6b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
v1-train: a444847bf1bb5833380b6a69e8b366bd5e26b6df
status-b2g18: --- → fixed
Whiteboard: interaction, UX-P1 → interaction, UX-P1, TEF_REQ
Blocks: 837652
blocking-b2g: tef? → tef+
status-b2g18-v1.0.0: --- → affected
v1.0.0: 901f77ac81a182794dab0b8a5a3948017b72bc47
status-b2g18-v1.0.0: affected → fixed
Created a test case for this issue:
https://moztrap.mozilla.org/manage/cases/?filter-id=6927
Flags: in-moztrap+
Whiteboard: interaction, UX-P1, TEF_REQ → interaction, UX-P1, TEF_REQ, QARegressExclude
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: