Closed Bug 833842 Opened 12 years ago Closed 11 years ago

The uninstall red cross shows up for installing app whereas it should not

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g18+)

RESOLVED WONTFIX
Tracking Status
b2g18 + ---

People

(Reporter: julienw, Unassigned)

References

Details

Attachments

(2 files)

STR:
* install app in http://everlong.org/mozilla/selfupdatingpackaged/
* when downloading, long press on its icon on the homescreen

Expected:
* all the removable apps gets a red cross, but not the big self updating app, because it's currently downloading

Actual:
* it gets its red cross, but it doesn't do anything.

Additionaly, I see this in the logcat :

E/GeckoConsole( 2492): [JavaScript Error: "NS_ERROR_INVALID_POINTER: Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIDOMMozURLProperty.createObjectURL]" {file: "app://homescreen.gaiamobile.org/js/page.js" line: 289}]


I'm not sure if the red cross should appear as soon as the app is correctly installed; I'd say ideally yes, but I don't really mind.
Attached image screenshot
Awkward, but an edge case. Definitely not going to block.
blocking-b2g: shira? → ---
Blocks: app-install
Details: check for the downloading case when creating the "options" span that displays the uninstall button and add the button when downloading is finished.
Attachment #728803 - Flags: review?(felash)
Attachment #728803 - Attachment filename: file_833842.txt → file_833842.html
Attachment #728803 - Attachment mime type: text/plain → text/html
As far as I remember, while downloading, if the user clicks on red cross, they could cancel the download and this patch doesn't implement it. Or am I wrong? Maybe I dreamt it jejeje
Hey,

I was going to ask Cristian about that :)

I think this bug is not current anymore and should be closed/wontfix. The real bug was that there was a red cross but it didn't do anything. Now it works correctly: we can uninstall an app while downloading. I don't remember which bug fixed that but I remember it was a gecko bug.

Cristian, what do you think about closing this bug wontfix ?

Thanks Mihai anyway for your patch, keep the good work ! I'll be happy to review another patch !
Flags: needinfo?(crdlc)
yes, close it please :) thanks for your work Mihai
Flags: needinfo?(crdlc)
Thanks for your work Mihai !

Next time, when the bug is old, you should definitely ask on the bug if it's still current before working on it.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Attachment #728803 - Flags: review?(felash)
Thanks Julien, Cristian, I'll make sure to ask next time :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: