Closed Bug 833886 Opened 11 years ago Closed 11 years ago

Bug 780561 broke comm-central

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

The intent was to avoid that, but it turns out the helpful change I made in packager.mk to attempt not to break comm-central ended up breaking it (it also turns out a comm-central build without a mozconfig doesn't enable calendar, which is where the build failed on c-c)
This will only trigger an error when MOZ_PACKAGER_FORMAT is not set *and* used. It appears calendar/locales/Makefile.in sets MOZ_CHROME_FILE_FORMAT for JarMaker.py *and* includes packager.mk probably for some variables defined there, but doesn't use the packaging rules. So the fact that MOZ_PACKAGER_FORMAT is not set doesn't really matter there, as long as it's not also used.
Attachment #705433 - Flags: review?(ted)
Attachment #705433 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/9c8777d256c7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: