833941 - [B2G][Email] Text in email body overlaps an image attachment details

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Mila Davydova]

Unagi, build 20130104070203

When user shares an image from the Gallery app via email and types a message in email body, the entered text overlaps an image attachment details. 
Screenshot is attached.

Repro Steps: 
1. Update Unagi Phone to build 20130123070202
2. Go to Gallery app
3. Select an image you want to share
4. Tap on “Share” icon 
5. Choose Share with: “Email” option from the menu
6. Type some text in email body

Actual Results: 
Text in email body overlaps an image attachment details

Expected Results:
Text in email body does not overlap an image attachment details

Notes:
-Repros 50%, only when attachment details are shown under the attachment icon.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Mila Davydova from comment #0)
> Screenshot is attached.

The screenshot didn't get attached yet; if you still have it handy, it would be great to have.

Comment 2

[Mila Davydova]

Attachment: Image shared via email

Comment 3

[sarsenyev]

Attachment: additional files

The text is overlaps in two cases:
With one attached picture, the attached file overlaps the text field
With three attached pictures, the attached files overlapping each other.

Comment 4

[Mila Davydova]

Issue still reproduces on Unagi device
Build ID: 20130225070200
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6

Comment 5

[Mila Davydova]

TC: https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=3994
UCID: email-131

Comment 6

[Nick Davidson]

In reference to Comment 4

Test Case # 3994
UCID: email-131

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=3994

Comment 7

[Michael Vines [:m1] [:evilmachines]]

(lets try leo? for now, if the patch looks low risk and is available soon then we can consider uplift to tef)

Comment 8

[Dietrich Ayala (:dietrich)]

Blocking for now.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/8614

Andrew, the change is minor. Please help review it, thanks!

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 724345 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/8614

Thanks for the fix!  I've merged it since it's straightforward and no coordination is required.

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/8614

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 22dec4d8034e1fab8a562cb0cd2944adbe8dcdf7 as:
v1-train: 0a68958263c8a3d69d826a4d3ca934aaa72e8724

Comment 13

[Julien Wajsberg [:julienw]]

Was landed in v1.0.1 as part of Bug 851124 big uplift.
Will land (again) in v1-train tomorrow at the latest too.

Comment 15

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified fixed w/ 

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/af9270e8f205
Gaia   a78ebf426840b5ef08c0cc3e437ad30aba3e2528
BuildID 20130318070202
Version 18.0
Unagi

Comment 16

[Julien Wajsberg [:julienw]]

Landed in v1-train as part of Bug 851124 big uplift.