834069 - Create a command to list sources in the debugger

Status: RESOLVED FIXED

Description

[Rob Campbell [:rc] (:robcee)]

'Twould be nice to have a command to list loaded sources in the debugger via the command line.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Created attachment 705633 [details] [diff] [review]
debug list WIP

WIP needs a test

Comment 2

[Rob Campbell [:rc] (:robcee)]

Created attachment 705663 [details] [diff] [review]
dbg list

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 705663 [details] [diff] [review]
dbg list

Review of attachment 705663 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! We might want to extend it in the future to choose between the original or unminified scripts, but this is fine for now.

::: browser/devtools/commandline/BuiltinCommands.jsm
@@ +1270,5 @@
> +    exec: function(args, context) {
> +      let dbg = getPanel(context, "jsdebugger");
> +      let doc = context.environment.chromeDocument;
> +      if (!dbg) {
> +        return gcli.lookup("debuggerStopped");

This prints: "The debugger must be opened before setting breakpoints". I think we should either add a new string or maybe make the existing one more generic ("The debugger must be opened first" or "The debugger must be open for this operation to proceed").

Comment 4

[Rob Campbell [:rc] (:robcee)]

ah yeah, good point. I'll add a new, more generic string.

Had the idea for a couple of optional parameters, a filter string if you want to limit your search by domain or filename and your suggestion's a good one as well.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Created attachment 705845 [details] [diff] [review]
dbg list updated

added a new string for debuggerClosed.

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/82196bf32137

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82196bf32137