834146 - Media Element doesn't initialize visibility state into AudioChannelAgent when starting to play.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Marco Chen [:mchen]]

Open bug from https://bugzilla.mozilla.org/show_bug.cgi?id=821627#c7

## Repro :
1. Play a song in music app
2. launch video
3. select a video (not play yet)
4. wait until the song from music app switches to the next song
5. play a video

## Expected :
1. music app stops, video plays sound

## Actual :
1. music app continues to play, video plays the sound as well.

Note:
I believe it has to do when the music switches to the next song that it over rides, because it kills the thread for the song and opens a new thread.

Comment 1

[Marco Chen [:mchen]]

Attachment: Patch v1

Root cause:
  If the music player try to play the next song in the background, a new AudioChannelAgent will be created but not set visibility well actively in that time. And the initial state of visibility in AudioChannelAgent is visible so in this case it will use visible state to register into AudioChannelService.

Solution:
  When creating AudioChannelAgent, try to set up initial visibility state.

Comment 2

[Andrew Overholt [:overholt]]

This blocks a tef+ blocker so needs to be tef+ itself.

Comment 3

[Marco Chen [:mchen]]

All green in try server.

https://tbpl.mozilla.org/?tree=Try&rev=b21c3fc83c9c.

Comment 4

[Marco Chen [:mchen]]

Attachment: Patch Checkin-Version

Add reviewer and a=tef+ in commit message.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ea6e1d489f3

Comment 6

[Johnny Stenback (:jst)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/56254819e70e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3ea6e1d489f3

Comment 8

[Cody Roesch [:croesch]]

Unagi Build ID: 20130313070202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e74dafa6b2d9
Gaia: b34e726147f8e671ad8c538b50900ccfbffcb084
Kernel: Dec 5th

Unable to get the bug to repro on the build above. Playing a song in Music with other songs in Queue then trying to play a video at the song switch does not seem to cause music to play over the top of the video. I've tried multiple timing scenarios and could not repro. Marking as Verified fixed.