834182 - enabling word suggestion with Czech causes homescreen to bleed through, no word suggestion

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Leo]

1. Title : UI issue with word suggestion bar in keypad.
2. Precondition : Settings >> Keyboard >> Select Word Suggestion >> Select English,and other Languages
3. Tester's Action : Contacts >> Add Contacts >> Click text box >> long press Globe icon >> English >> Word suggestion bar shown >> Press globe icon                       
4. Detailed Symptom (ENG.) : On again pressing globe icon,part of home screen appears in place of word suggestion bar and then disappear. 
5. GAIA version : 7b8dea7e7ec377a2143151bbe5e9998d87f7b36d
6. Expected : Word suggestion bar should disappear without any appearance of home screen.
7.Reproducibility: Y
1)Frequency Rate : 100%
8.Comparison Results : 
1)Model Comparing : 
9. Attached files: 
1)Log : 
2)Test Contents : 
3)Video file :

Comment 1

[Walter Chen[:ypwalter][:wachen]]

I confirmed this in unagi_2013-01-24_eng.zip (pvt b2g18 build).

Part of the home screen would show in this condition, but only for about a sec.

Comment 2

[Tony Chung [:tchung]]

not blocking-b2g, v1 isnt shipping with word suggestion on by default.

Comment 3

[Leo]

From English, if you change to Polski, the word suggestion bar diappeard and part of homescreen is shown

Comment 4

[Alex Keybl [:akeybl]]

qawanted for comment 3 - we're worried word suggestions can be enabled even when they're not available for a locale (this would likely be tef+ in that case).

This may also be a blocker if we end up enabling word suggestion by default. Lucas - can you relate the enabling bug to this?

Comment 5

[isabelrios]

(In reply to Alex Keybl [:akeybl] from comment #4)
> qawanted for comment 3 - we're worried word suggestions can be enabled even
> when they're not available for a locale (this would likely be tef+ in that
> case).

This is happening on v1.0.1. 04/03 build:
Gaia 819afb8
Gecko 545dda3
When long pressing on the globe key from English to Polish, or Arabic or other languages with no word suggestions, the homescreen is shown for a few seconds in the place of the word suggestion bar. For Spanish or Portuguese since the suggestion bar does not dissapear, the behaviour is correct

Comment 6

[Daniel Coloma:dcoloma]

Polish is supposed to have text prediction as soon as bug 850256 lands (tef+ already). So I assume this won't be an issue when launching 1.0.1 as all the supported languages (Spanish, English, Polish and Portuguese) should have text prediction available.

Comment 7

[Alex Keybl [:akeybl]]

Thanks Daniel. Given bug 850256, the Polish behavior wouldn't be a blocker. The behavior for other languages is just polish in our opinion, so not blocking.

Comment 8

[Leo]

Will the word prediction will be supported for every language?

If the word prediction is supported for every language,
the word suggestion bar will not hide when keyboard language 
is changed and this issue will not appear.
Please give your suggestion.

Comment 9

[Leo]

Ceska, Norsk, Slovencina also not support word suggestion. It's not solve this issue by supporting only Polish word suggestion

Comment 10

[Lucas Adamski [:ladamski]]

Not sure this actually blocks it, but adding the default word suggestion enabling bug per the needinfo.

Comment 11

[Alex Keybl [:akeybl]]

Czech is v1.0.1, so this is tef+

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I think we have 2 ways to go for this issue.

1. Always show the suggestion candidate bar.
   Please note that with the current implementation, the word suggestion depends on user language instead of keyboard layout.
   That is to say, when the user language is set as English, it will also show English suggestions even when the current active keyboard is Polish.
   If we want to keep this behavior, then it would be ok to always show the suggestion bar.
   
2. Find a way to correct the timing for app window resize.
   What we want is "Adjust the app window size" first and then modify the keyboard height.
   This involves a communication between keyboard app and system app, and seems not that easy to achieve. Will study if this is feasible.

Thanks.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9087

Pointer to Github pull-request

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 735713 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9087

[Root Cause]
The keyboard will update its UI first (for hiding suggestion bar) and then the app window size will be changed.

[Solution]
1. (Workaround) Add a delay before the hiding, so we would inform the system app first to resize the app window and then do the keyboard UI update.

[Other issue addressed]
Also fix an issue that when we close the keyboard with suggestion bar, sometimes it would also show the homescreen background.
Solution - not to remove 'candidate-panel' class in hideIME() of render.js.


Hi Tim,

Could you please review this patch?
Thank you.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 735713 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9087

The 100ms delay might trigger possible racing issue, but Rudy couldn't produce it.

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/789c00c1b00795168fb909c814d3d34e3a7b4eea

Tim,

Thanks for the review.

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 789c00c1b00795168fb909c814d3d34e3a7b4eea as:
v1-train: d2d09443750faf300fa02214f564efc4f63417f8
v1.0.1: 75a7dbefc330f8b5350ce61a228906295f394dfe

Comment 18

[Walter Chen[:ypwalter][:wachen]]

verified fixed in 2013/4/17 pub pvt build

Comment 19

[Leo]

There is still one case where homescreen is appearing and disappearing.
Whenever keyboard is changed to another format, the homescreen comes and disappears.

Go to contact >> add contact >> select name >> then select Email or select Mobile 

OR go to Calendar >> Add account  >> select username >> then select password

When the keyboard format is changing,this issue is still reproducing.

Comment 20

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, what you mentioned in Comment 19 is an issue that depends on Bug 819593.
Could you please comment on that bug or create another one if you don't think it fits your description.

Thank you.