834192 - Move injection of `console` from Worker to Symbiont

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Matteo Ferretti [:zer0] [:matteo]]

As noted by Alex here:

<https://github.com/mozilla/addon-sdk/pull/722/files#r2744310>

`console` should be injected earlier in the documents, and Symbiont seems the perfect place, because it also remove the needed to check if the document is in a Tab or not.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Also, we should take this occasion to remove the unnecessary use of `__exposedProps__`, as we imagined (see https://bugzilla.mozilla.org/show_bug.cgi?id=731074#c19).

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

With detraitification and ultimately removing Symbiont (only widget is depending on this IIRC now), is this PR still valid?

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

I guess it depends how it will works then the injected console in the documents without the Symbiont.
We need to inject early in the document anyway.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

This is done in the sdk/content/sandbox module now, https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/content/sandbox.js#L216-L262