834263 - consolidate ClonedMessageData unpacking code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: consolidate ClonedMessageData unpacking code

This is the counterpart of bug 834106, only on the receiving side.  Unfortunately,
these have to be free functions, because all the callsites don't have visibility
on MessageManagerCallback's methods.  nsFrameMessageManager.h seemed like a
reasonable place to put them, given what we already have.

The explicit spelling out of mozilla::dom::ipc::UnpackClonedMessageDataFor* seems
to be necessary to satisfy the linker.

There's still some cleanup opportunities between here and the IndexedDB code.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 705877 [details] [diff] [review]
consolidate ClonedMessageData unpacking code


>+    for (uint32_t index = 0; index < length; index++) {
++index please

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc0081ab6c4a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cc0081ab6c4a