Closed Bug 834290 Opened 7 years ago Closed 7 years ago

Add support for iPads and iPhones in useragent strings

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: david.weir, Assigned: LpSolit)

References

Details

Attachments

(1 file)

So aware it thinks the iphones running IOS 6 is mac x 

for when trying to guess what os you are running
OS: Windows 7 → All
Hardware: x86_64 → All
Attached patch patch, v1Splinter Review
Assignee: create-and-change → LpSolit
Status: NEW → ASSIGNED
Attachment #782852 - Flags: review?(dkl)
Summary: Iphone running IOS 6 → Add support for iPads and iPhones in useragent strings
Target Milestone: --- → Bugzilla 4.4
Comment on attachment 782852 [details] [diff] [review]
patch, v1

Review of attachment 782852 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #782852 - Flags: review?(dkl) → review+
Flags: approval?
Flags: approval4.4?
Given that neither iOS or separate versions are not in Bugzilla::DB's ENUM_DEFAULTS, should this patch really go upstream or is it better suited to BMO?
(In reply to Simon Green from comment #3)
> Given that neither iOS or separate versions are not in Bugzilla::DB's
> ENUM_DEFAULTS, should this patch really go upstream or is it better suited
> to BMO?

Upstream. We decided some years ago to implement the logic to get the correct platform and OS, and let admins add the ones relevant to their installation.
(In reply to Frédéric Buclin from comment #4)
> Upstream. We decided some years ago to implement the logic to get the
> correct platform and OS, and let admins add the ones relevant to their
> installation.

Thanks for the clarification.
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/UserAgent.pm
Committed revision 8681.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/UserAgent.pm
Committed revision 8587.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Hi matt do you know the user ident for the touch
Flags: needinfo?(mnoorenberghe+bmo)
Wrong bug it seems. In bug 905537 comment 0 I explained that the regex's need to look for "iPod" as well as the two others.
Flags: needinfo?(mnoorenberghe+bmo)
You need to log in before you can comment on or make changes to this bug.