Add support for iPads and iPhones in useragent strings

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
Creating/Changing Bugs
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: David Weir (satdav), Assigned: Frédéric Buclin)

Tracking

unspecified
Bugzilla 4.4
Bug Flags:
approval +
approval4.4 +

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
So aware it thinks the iphones running IOS 6 is mac x 

for when trying to guess what os you are running
(Reporter)

Updated

5 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 1

4 years ago
Created attachment 782852 [details] [diff] [review]
patch, v1
Assignee: create-and-change → LpSolit
Status: NEW → ASSIGNED
Attachment #782852 - Flags: review?(dkl)
(Assignee)

Updated

4 years ago
Summary: Iphone running IOS 6 → Add support for iPads and iPhones in useragent strings
Target Milestone: --- → Bugzilla 4.4
Comment on attachment 782852 [details] [diff] [review]
patch, v1

Review of attachment 782852 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #782852 - Flags: review?(dkl) → review+

Updated

4 years ago
Flags: approval?
(Assignee)

Updated

4 years ago
Flags: approval4.4?

Comment 3

4 years ago
Given that neither iOS or separate versions are not in Bugzilla::DB's ENUM_DEFAULTS, should this patch really go upstream or is it better suited to BMO?
(Assignee)

Comment 4

4 years ago
(In reply to Simon Green from comment #3)
> Given that neither iOS or separate versions are not in Bugzilla::DB's
> ENUM_DEFAULTS, should this patch really go upstream or is it better suited
> to BMO?

Upstream. We decided some years ago to implement the logic to get the correct platform and OS, and let admins add the ones relevant to their installation.

Comment 5

4 years ago
(In reply to Frédéric Buclin from comment #4)
> Upstream. We decided some years ago to implement the logic to get the
> correct platform and OS, and let admins add the ones relevant to their
> installation.

Thanks for the clarification.
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
(Assignee)

Comment 6

4 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/UserAgent.pm
Committed revision 8681.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/UserAgent.pm
Committed revision 8587.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Blocks: 905537
(Reporter)

Comment 7

4 years ago
Hi matt do you know the user ident for the touch
Flags: needinfo?(mnoorenberghe+bmo)
Wrong bug it seems. In bug 905537 comment 0 I explained that the regex's need to look for "iPod" as well as the two others.
Flags: needinfo?(mnoorenberghe+bmo)
You need to log in before you can comment on or make changes to this bug.