Closed Bug 834376 Opened 9 years ago Closed 9 years ago

Move Android Sync PNG files from drawable to drawable-mdpi

Categories

(Android Background Services Graveyard :: Build & Test, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: nalexander, Assigned: nalexander)

References

()

Details

Attachments

(1 file)

We need few simple changes.
All PNG files that are currently in 
https://hg.mozilla.org/mozilla-central/file/fa969919b1bb/mobile/android/base/android-services-files.mk#l9
should be moved to "SYNC_RES_DRAWABLE_MDPI". The XML file stays with SYNC_RES_DRAWABLE.
Please make "hg mv" of the PNG files to drawable-mdpi folder (once I push my patch.. as that will create the drawable-mdpi folder).
Assignee: nobody → nalexander
Summary: Move PNG files from drawable to drawable-mdpi → Move Android Sync PNG files from drawable to drawable-mdpi
I developed this on top of the patch from Bug 834082 -- but I don't think it depends on that patch, since hg will auto-create mobile/android/base/resources/drawable-mdpi for the moved files.
Attachment #706015 - Flags: review?(rnewman)
(In reply to Nick Alexander :nalexander from comment #1)
> Created attachment 706015 [details] [diff] [review]
> Patch against m-i
> 
> I developed this on top of the patch from Bug 834082 -- but I don't think it
> depends on that patch, since hg will auto-create
> mobile/android/base/resources/drawable-mdpi for the moved files.

Just realized I didn't actually build against this patch.  Will build locally, and push to try now to verify no unexpected shenanigans.
Comment on attachment 706015 [details] [diff] [review]
Patch against m-i

Review of attachment 706015 [details] [diff] [review]:
-----------------------------------------------------------------

If it builds, I'm happy!
Attachment #706015 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/df36c1dbecf9
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla21
Try run for a626255bb5f5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a626255bb5f5
Results (out of 36 total builds):
    exception: 1
    success: 33
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/nalexander@mozilla.com-a626255bb5f5
https://hg.mozilla.org/mozilla-central/rev/df36c1dbecf9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Android Sync: Build & Test → Build & Test
Product: Mozilla Services → Android Background Services
You need to log in before you can comment on or make changes to this bug.