834376 - Move Android Sync PNG files from drawable to drawable-mdpi

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Build & Test, defect)

Description

[Nick Alexander :nalexander [he/him]]

We need few simple changes.
All PNG files that are currently in 
https://hg.mozilla.org/mozilla-central/file/fa969919b1bb/mobile/android/base/android-services-files.mk#l9
should be moved to "SYNC_RES_DRAWABLE_MDPI". The XML file stays with SYNC_RES_DRAWABLE.
Please make "hg mv" of the PNG files to drawable-mdpi folder (once I push my patch.. as that will create the drawable-mdpi folder).

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Patch against m-i

I developed this on top of the patch from Bug 834082 -- but I don't think it depends on that patch, since hg will auto-create mobile/android/base/resources/drawable-mdpi for the moved files.

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #1)
> Created attachment 706015 [details] [diff] [review]
> Patch against m-i
> 
> I developed this on top of the patch from Bug 834082 -- but I don't think it
> depends on that patch, since hg will auto-create
> mobile/android/base/resources/drawable-mdpi for the moved files.

Just realized I didn't actually build against this patch.  Will build locally, and push to try now to verify no unexpected shenanigans.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 706015 [details] [diff] [review]
Patch against m-i

Review of attachment 706015 [details] [diff] [review]:
-----------------------------------------------------------------

If it builds, I'm happy!

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df36c1dbecf9

Comment 5

[Nick Alexander :nalexander [he/him]]

Merged in github develop:

https://github.com/mozilla-services/android-sync/commit/d41036f2f9f3b2ebe0a901c589e32d2441381916

Comment 6

[Mozilla RelEng Bot]

Try run for a626255bb5f5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a626255bb5f5
Results (out of 36 total builds):
    exception: 1
    success: 33
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a626255bb5f5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df36c1dbecf9