The default bug view has changed. See this FAQ.

Remove use of version.nsh from Sunbird

RESOLVED FIXED in 2.3

Status

Calendar
Sunbird Only
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rstrong, Unassigned)

Tracking

unspecified
x86
Windows 7

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #593148 +++

Filing now so I don't forget to do this.

Firefox no longer uses version.nsh after bug 592133 landed.

Sunbird should do the same for themselves as bug 592133 did for Firefox. After this is done, version.nsh should be removed.

Not sure what the state of Sunbird is at this time but it still references version.nsh so I'm going to remove that reference
Sunbird as a standalone product is discontinued. The current iterations of its code are as Lightning, a SeaMonkey and Thunderbird extension.

No consideration needs to be made with regard to Sunbird when it comes to installer.

Thank you none-the-less for the bug/issue.  Marking WONTFIX for now (albeit if it helps you to just remove the file[s] from the tree, go ahead, you have my rs+)
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
Created attachment 706007 [details] [diff] [review]
patch rev1 - since I had already created it

Works for me. Adding a patch in case anyone needs / wants it since I had it handy
Blocks: 593148
No longer depends on: 593148

Updated

4 years ago
Component: Calendar Views → Sunbird Only
Comment on attachment 706007 [details] [diff] [review]
patch rev1 - since I had already created it

I'm also fine with you just pushing this. Indeed Sunbird is no longer important, but no need to reject the patch if its there.
Attachment #706007 - Flags: review+
Pushed to comm-central
https://hg.mozilla.org/comm-central/rev/46eff8f0474d
Resolution: WONTFIX → FIXED

Updated

4 years ago
Target Milestone: --- → 2.3
You need to log in before you can comment on or make changes to this bug.