Last Comment Bug 834388 - Remove use of version.nsh from Sunbird
: Remove use of version.nsh from Sunbird
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Sunbird Only (show other bugs)
: unspecified
: x86 Windows 7
: -- normal (vote)
: 2.3
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks: 593148
  Show dependency treegraph
 
Reported: 2013-01-24 11:53 PST by Robert Strong [:rstrong] (use needinfo to contact me)
Modified: 2013-02-07 11:56 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch rev1 - since I had already created it (2.63 KB, patch)
2013-01-24 12:12 PST, Robert Strong [:rstrong] (use needinfo to contact me)
philipp: review+
Details | Diff | Splinter Review

Description Robert Strong [:rstrong] (use needinfo to contact me) 2013-01-24 11:53:45 PST
+++ This bug was initially created as a clone of Bug #593148 +++

Filing now so I don't forget to do this.

Firefox no longer uses version.nsh after bug 592133 landed.

Sunbird should do the same for themselves as bug 592133 did for Firefox. After this is done, version.nsh should be removed.

Not sure what the state of Sunbird is at this time but it still references version.nsh so I'm going to remove that reference
Comment 1 Justin Wood (:Callek) (Away until Aug 29) 2013-01-24 11:59:13 PST
Sunbird as a standalone product is discontinued. The current iterations of its code are as Lightning, a SeaMonkey and Thunderbird extension.

No consideration needs to be made with regard to Sunbird when it comes to installer.

Thank you none-the-less for the bug/issue.  Marking WONTFIX for now (albeit if it helps you to just remove the file[s] from the tree, go ahead, you have my rs+)
Comment 2 Robert Strong [:rstrong] (use needinfo to contact me) 2013-01-24 12:12:17 PST
Created attachment 706007 [details] [diff] [review]
patch rev1 - since I had already created it

Works for me. Adding a patch in case anyone needs / wants it since I had it handy
Comment 3 Philipp Kewisch [:Fallen] 2013-02-07 07:49:45 PST
Comment on attachment 706007 [details] [diff] [review]
patch rev1 - since I had already created it

I'm also fine with you just pushing this. Indeed Sunbird is no longer important, but no need to reject the patch if its there.
Comment 4 Robert Strong [:rstrong] (use needinfo to contact me) 2013-02-07 11:43:52 PST
Pushed to comm-central
https://hg.mozilla.org/comm-central/rev/46eff8f0474d

Note You need to log in before you can comment on or make changes to this bug.