834418 - Do not show apps in collections search suggestions

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[krupa raj[:krupa]]

Looks like collections auto-complete shows up two "Pearltrees" one of which is not even an add-on. Upon adding this non-existent add-on to a collection, this traceback was generated.

Collections auto-complete should only list public and valid add-ons as suggestions.

sentry: http://sentry.dmz.phx1.mozilla.com/addons/group/2206/

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Isn't this a dupe of bug 832302?

Comment 3

[Christopher Van Wiemeersch [:cvan]]

We will fix the traceback in bug  832302. For this bug, let's make sure they never show up in search suggestions.

Comment 4

[krupa raj[:krupa]]

STR:
1. Load https://addons.mozilla.org/en-US/firefox/collections/kr-raj/test-collection/edit/#addons-edit
2. Under the "Add-ons" tab, enter pearltrees
3. Notice the autocomplete options

observed behavior:
There are two Pearltrees listed in the autocomplete options and one of them is an app.

Comment 5

[Matt Basta [:basta]]

https://github.com/mozilla/zamboni/commit/28e351a472e8176957d150bbb5973cf99d524bd7

Comment 6

[krupa raj[:krupa]]

verified fixed at https://addons-dev.allizom.org/en-US/firefox/collections/kr-raj/hfclfehv/edit/#addons-edit

Comment 7

[krupa raj[:krupa]]

Attachment: post-fix screenshot