834446 - [Browser] Truncated Bookmark Label

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Patryk Adamczyk [:patryk] UX]

Attachment: Truncated Label drives me INSANE!

Pavel can you please fix this truncation? Ideally we wouldn't have to shrink the text string.
Try.
a) letter spacing
b) try a smaller font, weight 400, but not nothing smaller than 12px.

Spend me some screens before you make the patch. Thanks!

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: examples

I hope this variants are enough :) What do you think?

Comment 2

[Patryk Adamczyk [:patryk] UX]

Thanks for these, but Pavel, the fix would insure that "Bookma..." is not truncated. The label should be always read "Bookmarks" in english.

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Oh ... sorry I was thinking for the url's ... not for the title "Bookma..." ... I will give you new shots

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: examples - v2

What about this one?

Comment 5

[Patryk Adamczyk [:patryk] UX]

I'd go with the 1.3rem. I see you're using simulator. Just make sure it renders correctly on device as well. Thanks!

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: example - v3

device screenshot with :
font-size: 1.3rem;letter-spacing: -0.02rem;

Comment 7

[Patryk Adamczyk [:patryk] UX]

ship it :)

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for UX branch

Comment 9

[Sam Joch [:samjoch]]

Comment on attachment 706791 [details]
patch for UX branch

landed in uxbranch: https://github.com/gordonbrander/gaia/commit/c1981f5af9707cf1c62066144ef94d8b939dd8f0

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 11

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified on master, not on v1 train
Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"

Comment 13

[Stephany Wilkes]

Comment on attachment 706791 [details]
patch for UX branch

What is the status on this? Are we done-done and ready to go.

Comment 14

[Sam Joch [:samjoch]]

Comment on attachment 706791 [details]
patch for UX branch

Master commit hash is 63149e6

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: -
Testing completed: Yes see #c12
Risk to taking this patch (and alternatives if risky): no risk
String or UUID changes made by this patch: -

Comment 15

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 706791 [details]
patch for UX branch

This comes from the UX branch process where QA has already checked that it works. a=me.

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  63149e661d59b024aceb245d9085cfb29be2a42f
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 17

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Sam? can you help with this one?

Comment 18

[Sam Joch [:samjoch]]

This seems to conflict with https://bugzilla.mozilla.org/show_bug.cgi?id=830644 (https://github.com/mozilla-b2g/gaia/commit/e0d4130a). Is that (Bug 830644) bug going to be uplifted as well ?

Comment 19

[Stephany Wilkes]

What can we do to resolve this one?

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Stephany Wilkes from comment #19)
> What can we do to resolve this one?

Our choices are:

1) undo v1-train approval for this bug
2) approve v1-train for bug 830644
3) if it's a semantic-only merge conflict, the conflict can be resolved

Comment 21

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Sam Joch [:samjoch] from comment #18)
> This seems to conflict with
> https://bugzilla.mozilla.org/show_bug.cgi?id=830644
> (https://github.com/mozilla-b2g/gaia/commit/e0d4130a). Is that (Bug 830644)
> bug going to be uplifted as well ?

Welcome to the uplifting nightmare. This patch is probably way lighter than approving the whole set of patches of the responsive bug. So let's land this one first.

Comment 22

[Stephany Wilkes]

I like that idea, Vivien. Let's do that. And John and Vivien, thanks for the release/uplift onboarding too. ;)

Comment 23

[James Lal [:lightsofapollo]]

We can't do more here without conflicts resolved. Please supply a patch or uplift directly.

Comment 24

[Sam Joch [:samjoch]]

uplifted in v1-train: https://github.com/mozilla-b2g/gaia/commit/c9046a7acef33328977840176ff5574720d2c74c