Stop using deprecated history APIs in Chatzilla

NEW
Assigned to

Status

Other Applications
ChatZilla
5 years ago
5 years ago

People

(Reporter: mak, Assigned: Robert Ginda)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Please check bug 834457, Places is going to drop some of the old synchronous APIs and we'd appreciate your help in figuring out Chatzilla needs.

Comment 1

5 years ago
Thanks for the heads-up. We need to be able to add URLs to history such that links to that URLs show up visited (they are always irc: or maybe ircs: URLs).
Version: unspecified → Trunk
(Reporter)

Comment 2

5 years ago
Provided you use a toolkit with Places (I suppose so) you can use PlacesUtils.asyncHistory.updatePlaces API from javascript, it's asynchronous but I think may be fine for your needs.
From cpp you can use IHistory.h (this is what the docshell does)

Comment 3

5 years ago
My notes:
 - We support Gecko 1.9.1 so existing API must be a fallback.
 - Transition constants are from nsINavHistoryService not nsINavBookmarksService.
 - See browser_newtab_bug722273.js for example code.
 - ChatZilla code in /xul/content/static.js#l920.

I won't be able to get to this this weekend, most likely, but ChatZilla will run fine without nsIGlobalHistory2 existing (though it'll break if the API exists but throws on calling).
(Reporter)

Comment 4

5 years ago
Once the removal is done trying to instantiate an nsIGlobalHistory2 service instance should throw, since there will be nothing implementing the interface. you should not even be able to call its APIs then.
(Reporter)

Comment 5

5 years ago
I admit my ignorance here, is chatzilla code shared/same as comm-central /extensions/irc code? I see this http://mxr.mozilla.org/comm-central/source/mozilla/extensions/irc/xul/content/static.js#926 and I'm not sure if it requires a separate bug.

Btw, notice the removal in central may happen shortly (a couple days or beginning of the next week)
(In reply to Marco Bonardo [:mak] from comment #5)
> I admit my ignorance here, is chatzilla code shared/same as comm-central
> /extensions/irc code? [...]

comm-central mozilla/extensions/irc is a clone of the Chatzilla repository. Running "python client.py checkout" in a comm-central clone pulls the latest updates (or, for missing repositories, clones them) as follows:

comm-central    at ./
mozilla-central at ./mozilla/
ChatZilla       at ./mozilla/extensions/irc/
Venkman         at ./mozilla/extensions/venkman/
DOM Inspector   at ./mozilla/extensions/inspector/
LDAP SDK        at ./ldap/sdks/

Building SeaMonkey includes building the three extensions in ./mozilla/extensions/ above, plus the Debug and QA UI, as four XPIs packed in seamonkey/distribution/extensions/ which is where you can find them after downloading SeaMonkey from the ftp server and installing it.
(Reporter)

Updated

5 years ago
Depends on: 838874
You need to log in before you can comment on or make changes to this bug.