834528 - Should we remove the ability to set the OTA/App Update preset schedule to weekly and monthly?

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jason Smith [:jsmith]]

Talking with tchung, he mentions that the weekly and monthly settings for the preset schedule to check for updates points to dummy code - also known as "it doesn't work at all." If that's the case, we should disable the UI - it's a broken feature we've left in the build that someone will probably try to use.

This needs to be confirmed though by someone. Can someone confirm this?

Comment 1

[Jason Smith [:jsmith]]

Etienne - Do you know?

I don't really have a good way to test the preset schedule given the discussion we had on IRC.

Comment 2

[Etienne Segonzac (:etienne)]

Redirecting to Marshall, I remember him telling me that it was plugged in.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Etienne Segonzac (:etienne) from comment #2)
> Redirecting to Marshall, I remember him telling me that it was plugged in.

Do we know if it's plugged in for 3rd party app updates at least?

Comment 4

[Etienne Segonzac (:etienne)]

(In reply to Jason Smith [:jsmith] from comment #3)
> (In reply to Etienne Segonzac (:etienne) from comment #2)
> > Redirecting to Marshall, I remember him telling me that it was plugged in.
> 
> Do we know if it's plugged in for 3rd party app updates at least?

We check for app updates when we check for system updates, so we probably have both or none :)

Comment 5

[Marshall Culpepper [:marshall_law]]

(In reply to Jason Smith [:jsmith] from comment #0)
> This needs to be confirmed though by someone. Can someone confirm this?

This code should no longer be dummy -- it is hooked up directly to the Gecko pref that controls AUS (and implicitly, app update checking as well)

Comment 6

[Jason Smith [:jsmith]]

(In reply to Marshall Culpepper [:marshall_law] from comment #5)
> (In reply to Jason Smith [:jsmith] from comment #0)
> > This needs to be confirmed though by someone. Can someone confirm this?
> 
> This code should no longer be dummy -- it is hooked up directly to the Gecko
> pref that controls AUS (and implicitly, app update checking as well)

Okay, I'll close this then as invalid.

Btw - do you know of a good way to test the preset schedule easily without waiting for the timeframe to pass? Like flipping an about:config pref?

I'm looking to easily test daily, weekly, and monthly preset schedules are hooking up correctly.

Comment 7

[Dave Hylands [:dhylands]]

Probably the simplest way would be to modify gaia/apps/settings/index.html

Search for 86400 and change the 86400, 604800 and 2592000 to be smaller numbers. These are in units of seconds.

I'd probably recommend something like 600, 1200, 1800 (for 10, 20, 30 minutes), although you may need to make them a bit larger due to interactions with other timeouts.