[hotspot] "Show password" option is needed for Wi-Fi hotspot password

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: leo.bugzilla.gecko, Assigned: mihai)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:-, b2g18+)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
"Show password" option is needed for Wi-Fi hotspot password becasue of security reason. Anyone can see my phone screen when I turn on wi-Fi hotspot.

Updated

6 years ago
Assignee: nobody → evanxd
This would be *very* nice to have, but not serious security issue enough to block the entire release for 1.1.

Marking tracking+, would take a patch.
blocking-b2g: leo? → -
tracking-b2g18: --- → +
Evan, are you working on this bug? If not, I would like to take it (assign it to me if so).
Flags: needinfo?(evanxd)
Assignee: evanxd → mihai

Comment 3

6 years ago
Hi Mihai,

OK, you could take it. I'm working on another issue.

Thanks. :)
Flags: needinfo?(evanxd)
From my understanding, a "show password" checkbox should be available for the following: 
1. "Internet Sharing" main screen, where the password is displayed in plain view with the other hotspot configuration details
2. "HotSpot settings" screen, where a password can be inputted

While for point 2. the UI can be similar to the WiFi login screen, how should the UI for point 1. look like (i.e. where should the "show password" checkbox be placed)? or should the password be shown at all in this case?
Flags: needinfo?(kyee)

Comment 5

6 years ago
For the purposes of Internet sharing it is useful to show the password in plain view.  This is also why the password does not hide on entry and do not offer to show the password on the hotspot settings screens.

All other cases where passwords are entered for credential purposes we should be hiding entry [ie: *******d] and have the option to [ ] show password.
Flags: needinfo?(kyee)
Created attachment 733230 [details]
Pull Request #8984 - Add 'show password' functionality to HotSpot Settings

Based on Casey's comment I only left the 'show password' functionality for the HotSpot Settings (where the user inputs a password).
Attachment #733230 - Flags: review?(arthur.chen)
(Assignee)

Updated

6 years ago
Attachment #733230 - Attachment mime type: text/plain → text/html
Mihai, the patch looks good. However, with the patch once users check "show password", it remains checked until they restart settings app. I would suggest observing the url changes and unchecked "show password" when users enters the subpanel.
(In reply to Arthur Chen [:arthurcc] from comment #7)
> Mihai, the patch looks good. However, with the patch once users check "show
> password", it remains checked until they restart settings app. I would
> suggest observing the url changes and unchecked "show password" when users
> enters the subpanel.

Thanks for the feedback, Arthur! Updated the patch to reset the password input type and "show password" button state. Also added the r flag in the commit message, so feel free to merge it to master if everything looks good.
Comment on attachment 733230 [details]
Pull Request #8984 - Add 'show password' functionality to HotSpot Settings

r=me. Although I'm not sure about the UX is what the reporter want. Currently the password is hidden in the dialog but displayed in the main panel.
Attachment #733230 - Flags: review?(arthur.chen) → review+
master: https://github.com/mozilla-b2g/gaia/commit/f219c47b0b05ee73e9bf683bae30440863cb301e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Comment on attachment 733230 [details]
Pull Request #8984 - Add 'show password' functionality to HotSpot Settings

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): HotSpot Settings > create password
User impact if declined: Low (password is visible while typing)
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: No
Attachment #733230 - Flags: approval-gaia-v1?
Comment on attachment 733230 [details]
Pull Request #8984 - Add 'show password' functionality to HotSpot Settings

We're past the point of taking new enhancements/strings for non-blocking work. Apologies. This will first ship in v1.2.
Attachment #733230 - Flags: approval-gaia-v1? → approval-gaia-v1-
You need to log in before you can comment on or make changes to this bug.