Closed Bug 834596 Opened 9 years ago Closed 9 years ago

Graphserver posts for libxul link max vsize fail on mozilla-central, "No machine_name called 'WINNT_5.2_mozilla-central' can be found"

Categories

(Release Engineering :: General, defect)

x86
Windows Server 2008
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: armenzg)

References

Details

(Keywords: regression, Whiteboard: [buildduty])

Attachments

(3 files, 2 obsolete files)

Whiteboard: [buildduty]
Assignee: nobody → armenzg
I can land this.
Attachment #706347 - Flags: review?(armenzg) → review+
Deployed. Re-triggering a PGO build.
I will check which other branches are going to need this.

mysql> select * from machines where name like 'WINNT_5.2_mozilla-central';
+------+-------+---------------+-----------+---------------------------+-----------+------------+
| id   | os_id | is_throttling | cpu_speed | name                      | is_active | date_added |
+------+-------+---------------+-----------+---------------------------+-----------+------------+
| 6747 |     8 |             0 | NULL      | WINNT_5.2_mozilla-central |         1 | 1359122468 |
+------+-------+---------------+-----------+---------------------------+-----------+------------+
1 row in set (0.01 sec)
http://hg.mozilla.org/graphs/rev/d9283c4b6c9d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attached patch branches missing from data.sql (obsolete) — Splinter Review
I will work on the sql statement that I will actually need to deploy.
Attachment #706372 - Flags: review?(jmaher)
Comment on attachment 706372 [details] [diff] [review]
branches missing from data.sql

this isn't a patch, and you are missing the ending ) on the sql statements.
Attachment #706372 - Flags: review?(jmaher) → review-
Attachment #706378 - Flags: review?(jmaher)
Attachment #706378 - Attachment is obsolete: true
Attachment #706378 - Flags: review?(jmaher)
Attachment #706379 - Flags: review?(jmaher)
Attachment #706380 - Flags: review?(jmaher)
Attachment #706380 - Flags: review?(jmaher) → review+
Attachment #706372 - Attachment is obsolete: true
Attachment #706379 - Flags: review?(jmaher) → review+
Comment on attachment 706347 [details] [diff] [review]
add machine name to graph server repository

WINNT_5.2_mozilla-central already existed in data.sql (which I missed on my review).
I reverted it in my checkin.
Attachment #706347 - Flags: review-
Attachment #706347 - Flags: review+
Attachment #706347 - Flags: checked-in-
Comment on attachment 706379 [details] [diff] [review]
insert these missing pgo branches

Deployed and added ")" at the end of each statement.
Attachment #706379 - Flags: checked-in+
Comment on attachment 706380 [details] [diff] [review]
branches missing from data.sql

Landed with:
http://hg.mozilla.org/graphs/rev/6872778de2d4
Attachment #706380 - Flags: checked-in+
(In reply to Nick Thomas [:nthomas] from comment #14)
> Did anyone figure out why we had to add
>  http://hg.mozilla.org/graphs/annotate/d9283c4b6c9d/sql/data.sql#l1762
> when we already had exactly the same insert at 
>  http://hg.mozilla.org/graphs/annotate/d9283c4b6c9d/sql/data.sql#l1318

I did not notice when I reviewed it.

I only inserted that statement on the staging graphs DB thinking that it was only missing there when it was missing as well on production.

On this whole thing I noticed that there is a bunch of data not in data.sql as well as a bunch of data on the DB that is not data.sql.

Not sure how much we want to open the can of worms knowing that we will be switching to datazilla in the next quarter.
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.