Closed
Bug 834645
Opened 8 years ago
Closed 8 years ago
move -STACK parameter to config.mk
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file, 1 obsolete file)
5.17 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
xpcshell on Win64 uses 2MB stack size by bug 582910. Also, JS Sehll (js.exe) needs 2MB stack. mozjs requires 2MB stack size, so -STACK:2097152 should be moved to config.mk.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #706323 -
Flags: review?(ted)
Comment 2•8 years ago
|
||
Comment on attachment 706323 [details] [diff] [review] fix This also changes the value for all other executables including firefox, is that wanted?
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2) > Comment on attachment 706323 [details] [diff] [review] > fix > > This also changes the value for all other executables including firefox, is > that wanted? thansk, I forget browser/*, xulrunner/*, and winembed.
Assignee | ||
Updated•8 years ago
|
Attachment #706323 -
Flags: review?(ted)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #706323 -
Attachment is obsolete: true
Attachment #709645 -
Flags: review?(ted)
Comment 5•8 years ago
|
||
Comment on attachment 709645 [details] [diff] [review] fix Review of attachment 709645 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/app/Makefile.in @@ +115,5 @@ > # > # Set it to 256k. See bug 127069. > # > ifndef GNU_CC #{ > LDFLAGS += /HEAP:0x40000 I'm surprised that this works with a / in it.
Attachment #709645 -
Flags: review?(ted) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3cba77064cd
Target Milestone: --- → mozilla21
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f3cba77064cd
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•