834645 - move -STACK parameter to config.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

xpcshell on Win64 uses 2MB stack size by bug 582910.  Also, JS Sehll (js.exe) needs 2MB stack.   mozjs requires 2MB stack size, so -STACK:2097152 should be moved to config.mk.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 706323 [details] [diff] [review]
fix

This also changes the value for all other executables including firefox, is that wanted?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Mike Hommey [:glandium] from comment #2)
> Comment on attachment 706323 [details] [diff] [review]
> fix
> 
> This also changes the value for all other executables including firefox, is
> that wanted?

thansk, I forget browser/*, xulrunner/*, and winembed.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 709645 [details] [diff] [review]
fix

Review of attachment 709645 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/Makefile.in
@@ +115,5 @@
>  #
>  # Set it to 256k.  See bug 127069.
>  #
>  ifndef GNU_CC #{
>  LDFLAGS += /HEAP:0x40000

I'm surprised that this works with a / in it.

Comment 6

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3cba77064cd

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f3cba77064cd