Closed Bug 834648 Opened 12 years ago Closed 12 years ago

[Contacts. UX VD] Contact details. Layout's spacing needs to be adjusted

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 fixed, b2g18-v1.0.1 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: vicky, Assigned: alberto.pastor)

References

Details

(Whiteboard: interaction, UX-P2, [TEF_REQ])

Attachments

(2 files)

Shows comparison between actual phones screen shot and original design
127.33 KB, image/png
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8009
355 bytes, text/html
basiclines
: review+
akeybl
: approval-gaia-v1+
Details
Contact detail's screen needs spacing adjustment to get information hierarchy right. Since there are no evident dividers, the correct spacing here is key to cluster information correctly. Please refer to attachment.
Whiteboard: interaction, UX-P2, [TEF_REQ]
Blocks: 836244
NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky):
Attachment #711362 - Flags: review?(igonzaleznicolas)
Attachment #711362 - Flags: review?(igonzaleznicolas) → review+
Assignee: nobody → alberto.pastor
Comment on attachment 711362 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8009 NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky): 0 risky style bug
Attachment #711362 - Flags: approval-gaia-v1?(21)
Attachment #711362 - Flags: approval-gaia-v1?(21) → approval-gaia-v1?
Comment on attachment 711362 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8009 Approving for v1.0.1. If we find any regressions from this (shortened strings in localizations), we'll backout immediately.
Attachment #711362 - Flags: approval-gaia-v1? → approval-gaia-v1+
https://github.com/mozilla-b2g/gaia/commit/ad5bf1cdd8025f929ad6e124d10973e29eda5b0d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Backed out due a bug when adding the shadow in a FB contact. I'll upload new patch. https://github.com/mozilla-b2g/gaia/commit/d80f60b58fc0241030c0ceb9fa9e12fa681b56fa
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Sorry, forget last comment. I meant Bug 818034
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
v1-train: 8ca5e4d79a0be462a7dacd342c1737761570566b
status-b2g18: --- → fixed
status-b2g18-v1.0.1: --- → fixed
Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: