834696 - [Transitions. UX] Implement Switching tabs transitions as specified.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Please refer to specs: 
https://www.dropbox.com/sh/ekzrrz7um4uj6y0/NVzqB1D4hx/03%20Transitions
TransitionsVXX.pdf (latest version)
(Page 23 of transitions V13)

Lack of Transitions affect the experience. Required for TEF build.
Transitions a key feature to give the user a clue of the architecture of the OS and how to navigate it.

Comment 1

[Salvador de la Puente González [:salva]]

Attachment: Implementing new tab transitions and avoiding disturbing blank flash when disposing settings

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this one
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 713376 [details]
Implementing new tab transitions and avoiding disturbing blank flash when disposing settings

Easy patch,

most of the changes are dom and css related, and the JS ones are mostly reorganising the code in a better way.

Thanks Salva!

Comment 3

[Salvador de la Puente González [:salva]]

Master: b9ef9938ac2458c54361291614de0a3446a1c0ea

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 713376 [details]
Implementing new tab transitions and avoiding disturbing blank flash when disposing settings

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this one
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 713376 [details]
Implementing new tab transitions and avoiding disturbing blank flash when disposing settings

This feels like a large UX change to be taking at the last minute, even if we think the risk is low. Approving for v1-train (v1.1) but we'll wontfix for v1.0.1.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 8de47563af9dc90ca0808d103ce04a01120a1b3d

Comment 7

[Salvador de la Puente González [:salva]]

(In reply to Alex Keybl [:akeybl] from comment #5)
> This feels like a large UX change to be taking at the last minute, even if
> we think the risk is low. Approving for v1-train (v1.1) but we'll wontfix
> for v1.0.1.

Please, consider this for V1.0.1. It is only a low risk patch to update transitions to latest ones and furthermore, it solves a bug already reported: bug #811844

Comment 8

[Salvador de la Puente González [:salva]]

Hey, what happen here, I only clicked on "Edit" in Tracking Flags and write a comment and some flags (which I don't have even permissions to edit) have been reset to ---.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Per comment 7, setting tef? and holding off on uplift

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Triage today considers comment 5 to still stand.  This is on v1-train already, resetting the status flags accordingly.