834745 - UndefinedError: 'None' has no attribute 'all_files' for status page

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[Rob Hudson [:robhudson]]

http://sentry.dmz.phx1.mozilla.com/marketplace/group/11040/

Rejected apps don't have a `current_version`, so this fails in the template.

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "amo/decorators.py", line 160, in wrapper
    return f(*args, **kw)
  File "amo/decorators.py", line 152, in wrapper
    return f(*args, **kw)
  File "addons/decorators.py", line 33, in wrapper
    return f(request, addon, *args, **kw)
  File "amo/decorators.py", line 33, in wrapper
    return func(request, *args, **kw)
  File "mkt/developers/decorators.py", line 65, in wrapper
    return fun()
  File "mkt/developers/decorators.py", line 28, in <lambda>
    *args, **kw)
  File "mkt/developers/views.py", line 229, in status
    return jingo.render(request, 'developers/apps/status.html', ctx)
  File "jingo/__init__.py", line 80, in render
    rendered = render_to_string(request, template, context)
  File "jingo/__init__.py", line 98, in render_to_string
    return template.render(**get_context())
  File "jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/www/addons.mozilla.org/zamboni/mkt/developers/templates/developers/apps/status.html", line 11, in top-level template code
    <strong class="status {{ mkt_status_class(addon) }}">{{ msg }}</strong>
  File "/data/www/addons.mozilla.org/zamboni/mkt/developers/templates/developers/base_impala.html", line 8, in top-level template code
    {% set editable = "no-edit" if not check_addon_ownership(request, addon, dev=True) %}
  File "/data/www/addons.mozilla.org/zamboni/mkt/developers/templates/developers/skeleton_impala.html", line 94, in top-level template code
    {% block main_content %}
  File "/data/www/addons.mozilla.org/zamboni/mkt/developers/templates/developers/skeleton_impala.html", line 97, in block "main_content"
    {% block content %}{% endblock %}
  File "/data/www/addons.mozilla.org/zamboni/mkt/developers/templates/developers/apps/status.html", line 203, in block "content"
    {% if action_allowed('Apps', 'Configure') and versions and addon.current_version.all_files[0].status != amo.STATUS_BLOCKED %}
  File "jinja2/environment.py", line 352, in getitem
    return obj[argument]

Comment 1

[Rob Hudson [:robhudson]]

r? https://github.com/robhudson/zamboni/commit/c8ce98c

Comment 2

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/75a7e71

Comment 4

[krupa raj[:krupa]]

rejected apps don't traceback- https://marketplace-dev.allizom.org/developers/app/test-app-baubau49/status