Exception from removing selection listeners

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: canuckistani, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

When testing bug 832668, I noticed this traceback when disabling an add-on that uses the selection module:

[JavaScript Error: "selection-test: An exception occurred.
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISelectionPrivate.removeSelectionListener]
undefined 353
Traceback (most recent call last):
  File "resource://jid1-ixviqlnchxvyzq-at-jetpack/addon-sdk/lib/sdk/selection.js", line 353, in removeSelectionListener
    selection.removeSelectionListener(selectionListener);
  File "self-hosted", line 323, in forEach
  File "resource://jid1-ixviqlnchxvyzq-at-jetpack/addon-sdk/lib/sdk/selection.js", line 420, in null
    getAllTabContentWindows().forEach(removeSelectionListener);
  File "resource://jid1-ixviqlnchxvyzq-at-jetpack/addon-sdk/lib/sdk/system/unload.js", line 58, in null
    observer(reason);
  File "self-hosted", line 323, in forEach
  File "resource://jid1-ixviqlnchxvyzq-at-jetpack/addon-sdk/lib/sdk/system/unload.js", line 56, in unload
    observers.forEach(function(observer) {
  File "resource://jid1-ixviqlnchxvyzq-at-jetpack/addon-sdk/lib/sdk/system/unload.js", line 77, in onunload
    unload(reason);
  File "resource://jid1-ixviqlnchxvyzq-at-jetpack/addon-sdk/lib/sdk/system/events.js", line 62, in null
    data: data
  File "resource://jid1-ixviqlnchxvyzq-at-jetpack/addon-sdk/lib/toolkit/loader.js", line 368, in unload
    notifyObservers(subject, 'sdk:loader:destroy', reason);
  File "jar:file:///Users/jeff/Library/Application%20Support/Firefox/Profiles/b49h24eg.default/extensions/jid1-ixvIqlNCHxvyZQ@jetpack.xpi!/bootstrap.js", line 229, in shutdown
    unload(loader, reason);
  File "resource://gre/modules/XPIProvider.jsm", line 3743, in XPI_callBootstrapMethod
    this.bootstrapScopes[aId][aMethod](params, aReason);
  File "resource://gre/modules/XPIProvider.jsm", line 3863, in XPI_updateAddonDisabledState
    BOOTSTRAP_REASONS.ADDON_DISABLE);
  File "resource://gre/modules/XPIProvider.jsm", line 6136, in AddonWrapper_userDisabledSetter
    XPIProvider.updateAddonDisabledState(aAddon, val);
  File "chrome://mozapps/content/extensions/extensions.xml", line 1023, in set_userDisabled
    this.mAddon.userDisabled = val;
  File "about:addons", line 1, in oncommand
    <?xml version="1.0"?>
"]
Note:, this is using Firefox 20.
Note:, this is using Firefox 20, and also it seems to be inconsistent. I've triggered it only a couple of times doing some combination of enabling, disabling and selecting things. Leaving for discussion at triage.
Blocks: 836564
As mentioned here: https://bugzilla.mozilla.org/show_bug.cgi?id=832668#c6 this bug was already fixed in bug 820095, but never merged with stabilization branch; it will be added in hotfix 1.13.1 (see Bug 836564)
released in 1.13.1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.