834879 - Skip the identityFlow during a second purchase (auto login)

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Payments/Refunds, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Launch marketplace-dev on your unagi phone
2. Search for Private yacht
3. click on the purchase button
4. Sign in and complete the purchase
5. Search for another paid app
6. Click the purchase button


expected behavior:
Step #6 will open the 'Enter your PIN' in the trusted UI.

observed behavior:
Step #6 opens the identityflow (with the email preselected)

Comment 1

[Kumar McMillan [:kumar]]

This was a regression from when we added the forceIssuer call. Fixed https://github.com/mozilla/webpay/commit/26d5513148c78c0994003d9b8cf55c8c5d21f50b

Comment 2

[Kumar McMillan [:kumar]]

oops, I forgot that b2g2pac is the only whitelisted force issuer. I put it back.

After step #6, nav.id.watch() used to automatically log us in but that no longer works.

jedp, ozten: Any ideas here? we are doing this: https://github.com/mozilla/zamboni/blob/master/media/js/mkt/login.js 

Also, the same behavior happens on the separate webpay server, which is doing 5this https://github.com/mozilla/webpay/blob/master/media/js/pay/pay.js 

both have forceIssuer: "b2g2pac.personatest.org"

I stated noticing this bug today. Did anything change? It might have happened earlier.

Comment 3

[Kumar McMillan [:kumar]]

To clarify: when I remove forceIssuer from nav.id.request() then this bug goes away

Comment 4

[Austin King [:ozten]]

I don't think anything has changed recently server side.

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

There haven't been any server-side changes for native-persona.org, no.

I will try to reproduce this, but I need to know what to do when I get to the part of the payment flow that asks me to confirm my mobile number.  I'm using an unagi dev phone with no sim card.

In the mean time, to see what's going on with persona, you can set the pref toolkit.identity.debug to true, and adb lolcat.  (It's a bit redundant - the logs get printed for both Gecko and GeckoConsole for some reason.)

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

krupa pointed out that i can cancel the flow at this point and just jump to purchase a different paid app.

I did that and followed the logcat, and I am actually being logged in automatically.  I get prompted for my PIN right away.

So ... yay?  I think this is the desired behavior?

Comment 7

[Kumar McMillan [:kumar]]

Well, huh. It is working now on the -dev server so I'll close it. However, it still happens on my localhost. Maybe something in the URL bar is tripping up identity. Either way, if it works on dev I'm not too worried about it.