834882 - Make InParallelSection() a function rather than a static method of ForkJoinSlice

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Niko Matsakis [:nmatsakis]]

Just because it will read better.  This came up in bug 825714 but I decided to just make a separate bug for the patch rather than tacking it on there.

Comment 1

[Niko Matsakis [:nmatsakis]]

Attachment: Move InParallelContext() out of ForkJoinSlice and rename Initialize() to InitializeTLS()

I opted to leave Initialize() as a member of ForkJoinSlice since it, well, initialized the ForkJoinSlice class.  It also accesses private fields (the TLS data).  But I renamed it to make it clearer.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 706688 [details] [diff] [review]
Move InParallelContext() out of ForkJoinSlice and rename Initialize() to InitializeTLS()

Review of attachment 706688 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 3

[Niko Matsakis [:nmatsakis]]

Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/c232abeabd0a

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c232abeabd0a