Closed Bug 834882 Opened 10 years ago Closed 10 years ago

Make InParallelSection() a function rather than a static method of ForkJoinSlice

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: nmatsakis, Unassigned)

References

Details

Attachments

(1 file)

Just because it will read better.  This came up in bug 825714 but I decided to just make a separate bug for the patch rather than tacking it on there.
Blocks: PJS
I opted to leave Initialize() as a member of ForkJoinSlice since it, well, initialized the ForkJoinSlice class.  It also accesses private fields (the TLS data).  But I renamed it to make it clearer.
Attachment #706688 - Flags: review?(wmccloskey)
Comment on attachment 706688 [details] [diff] [review]
Move InParallelContext() out of ForkJoinSlice and rename Initialize() to InitializeTLS()

Review of attachment 706688 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #706688 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/c232abeabd0a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.