Closed Bug 834896 Opened 7 years ago Closed 7 years ago

Replace gfx_min/gfx_max with std::min/std::max

Categories

(Core :: Graphics, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: mats, Assigned: mats)

References

Details

Attachments

(2 files)

This should be an easy fix now that bug 786533 worked around the system
header file issues mentioned on line 16:
http://mxr.mozilla.org/mozilla-central/source/gfx/2d/BaseRect.h#11
Attachment #706593 - Flags: review?(ehsan)
Comment on attachment 706593 [details] [diff] [review]
Remove the gfx_min/gfx_max templates.

Review of attachment 706593 [details] [diff] [review]:
-----------------------------------------------------------------

These patches look good, but IIRC there's some strange rules going on with the code in gfx/2d.  I've been told to not touch that code in the past.  Forwarding to Joe.
Attachment #706593 - Flags: review?(ehsan) → review?(joe)
Attachment #706594 - Flags: review?(ehsan) → review?(joe)
Comment on attachment 706594 [details] [diff] [review]
Replace uses of gfx_min/gfx_max with std::min/std::max. (automated)

Review of attachment 706594 [details] [diff] [review]:
-----------------------------------------------------------------

If this builds everywhere, there are no problems. (Our issue was that it didn't build on Mac iirc).
Attachment #706594 - Flags: review?(joe) → review+
Attachment #706593 - Flags: review?(joe) → review+
https://hg.mozilla.org/mozilla-central/rev/c8cf23a719b7
https://hg.mozilla.org/mozilla-central/rev/a9ba0d917358
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.