834896 - Replace gfx_min/gfx_max with std::min/std::max

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Mats Palmgren (inactive)]

This should be an easy fix now that bug 786533 worked around the system
header file issues mentioned on line 16:
http://mxr.mozilla.org/mozilla-central/source/gfx/2d/BaseRect.h#11

Comment 1

[Mats Palmgren (inactive)]

Attachment: Remove the gfx_min/gfx_max templates.

Comment 2

[Mats Palmgren (inactive)]

Attachment: Replace uses of gfx_min/gfx_max with std::min/std::max. (automated)

Comment 3

[Mats Palmgren (inactive)]

Green on Try:  https://tbpl.mozilla.org/?tree=Try&rev=2bfe2ca83a54

Comment 4

[(no longer active)]

Comment on attachment 706593 [details] [diff] [review]
Remove the gfx_min/gfx_max templates.

Review of attachment 706593 [details] [diff] [review]:
-----------------------------------------------------------------

These patches look good, but IIRC there's some strange rules going on with the code in gfx/2d.  I've been told to not touch that code in the past.  Forwarding to Joe.

Comment 5

[Joe Drew (not getting mail)]

Comment on attachment 706594 [details] [diff] [review]
Replace uses of gfx_min/gfx_max with std::min/std::max. (automated)

Review of attachment 706594 [details] [diff] [review]:
-----------------------------------------------------------------

If this builds everywhere, there are no problems. (Our issue was that it didn't build on Mac iirc).

Comment 6

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8cf23a719b7
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9ba0d917358

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c8cf23a719b7
https://hg.mozilla.org/mozilla-central/rev/a9ba0d917358