83490 - autocomplete needs a non-allocating accessor

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Alec Flett]

in the global history code where we're returning a sorted set of entries to the
url bar, we do a tremendous amount of allocation in AutocompleteSortComparison
just to compare two strings.

what we really need is a way to access the data inside the nsIAutoCompleteItem
without any allocations.
patch forthcoming

cc'ing hewitt for sr=, and dmose because he might be interested in this stuff
for ldap

Comment 1

[Alec Flett]

Attachment: implement shared accessor and clean up IDL comments

Comment 2

[Alec Flett]

notes on this patch.. 
- nsCRT::strcmp() already does null checking/etc (implemented that myself over a
year ago :))
- fixed up the IDL comments to javadoc style, wrapping at < 80 columns, etc
- ignore that #if 0 code in nsGlobalHistory - I won't check that it, it's part
of another bug...

Comment 3

[Joe Hewitt (gone)]

thanks for cleaning up after me, alec.  sr=hewitt

Comment 4

[Alec Flett]

dmose suggested I try using AString - I'll have a new patch in a bit, after I
figure out what the impact of that is going to be..

Comment 5

[Alec Flett]

fix from bug 71903, using "AString" checked in.

Comment 6

[Alec Flett]

oops, marking fixed.

Comment 7

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]