834941 - Don't show topics for not yet approved articles on product landing page

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Ibai Garcia [:ibai]]

The Marketplace page https://support.mozilla.org/en-US/products/marketplace has 3 sections that should not show up:
- Tips and Tricks
- Flash
- Websites

If you access this groups, there's no content in then, but if you go to Refine and Focus, the 3 of them show up again with 1 article each. Although no article shows up.

Comment 1

[Michelle Luna]

This is also true for Firefox OS on the unagi phone, the main set of topics includes tips/tricks, flash, websites. But it doesn't include: customize controls/options/prefs, fix problems, and privacy & security.

Comment 2

[Kadir Topal [:atopal]]

The creation of topics is based on articles. In this case, Michelle had created an article that had "Tips and Trick", "Flash" and "Websites" marked as topics:

https://support.mozilla.org/en-US/kb/how-do-i-use-facebook-google-twitter-and-youtube-f/history

The article was not approved though, so there was nothing to show on the landing pages. That is a bug I'll file.

Comment 3

[Kadir Topal [:atopal]]

In fact, let's reuse this bug:

In case an article is not approved we should not show any topics for it on the product landing page, they should also not counted in the focus and refine panel.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Making this a 1pt to allocate for writing a test. Otherwise, it is a one line fix ish.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Doing this now.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/1097

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/aa728000289a19ed7e618c8c6f144ee9e903db0e

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod and looks good! https://support.mozilla.org/en-US/products/marketplace