834961 - pwpb update window util modules to ignore private windows

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/769

Pointer to Github pull-request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 711202 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/769

ready for another round

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 711202 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/769

Please make sure to address following comments before landing:

https://github.com/mozilla/addon-sdk/pull/769/files#r3198016
https://github.com/mozilla/addon-sdk/pull/769/files#r3198004


I made few others but I'd be ok fixing them in followup changes.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a76b7064dd6da8e79e8d2984f2f18c4b682d1d73
Bug 834961 - pwpb update window modules to ignore private windows

https://github.com/mozilla/addon-sdk/commit/bb69f6051e88b24bb8993c2a5016b91f278efcda
Merge pull request #825 from erikvold/834961-2

Fix Bug 834961 - pwpb update window modules to ignore private windows r=@gozala

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f7200c0f7d14599b5f8ad510ae333663d9d21e94
Bug 834961: fixes for the private-browsing test addon

https://github.com/mozilla/addon-sdk/commit/3c87ada3cb75c13063f126fdc1ad4afc257b91e6
Merge pull request #827 from erikvold/834961-fix

Bug 834961: fixes for the private-browsing test add-on a=@Gozala

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Looks like a bunch of private browsing tests are intermittently failing:
TEST-UNEXPECTED-FAIL | tests/test-windows.testWindowIteratorPrivateDefault | false != true
TEST-UNEXPECTED-FAIL | tests/test-window-utils-private-browsing.testSettingActiveWindowIgnoresPrivateWindow | Correct active window [1]
error: private-browsing-supported: fail: Correct active window [1]

Etc.


Timing issues, I guess?

Comment 7

[[github robot]]

Commits pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/980baf5c64fbc2dd91e192efaf5305e3e44bc2ba
Merge pull request #825 from erikvold/834961-2

Fix Bug 834961 - pwpb update window modules to ignore private windows r=@gozala

(cherry picked from commit bb69f6051e88b24bb8993c2a5016b91f278efcda)

Conflicts:

	lib/sdk/tabs/utils.js
	test/private-browsing/windows.js

https://github.com/mozilla/addon-sdk/commit/960c4f425018ccfb84dfe787e1e9e2346d08fd02
Merge pull request #827 from erikvold/834961-fix

Bug 834961: fixes for the private-browsing test add-on a=@Gozala(cherry picked from commit 3c87ada3cb75c13063f126fdc1ad4afc257b91e6)