Closed Bug 834961 Opened 10 years ago Closed 10 years ago

pwpb update window util modules to ignore private windows

Categories

(Add-on SDK Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

Details

Attachments

(1 file)

No description provided.
Depends on: 820582
Target Milestone: --- → 1.14
Assignee: nobody → evold
Attachment #711202 - Flags: review?(rFobic)
Attachment #711202 - Flags: review?(rFobic) → review-
Comment on attachment 711202 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/769

ready for another round
Attachment #711202 - Flags: review- → review?(rFobic)
Comment on attachment 711202 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/769

Please make sure to address following comments before landing:

https://github.com/mozilla/addon-sdk/pull/769/files#r3198016
https://github.com/mozilla/addon-sdk/pull/769/files#r3198004


I made few others but I'd be ok fixing them in followup changes.
Attachment #711202 - Flags: review?(rFobic) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a76b7064dd6da8e79e8d2984f2f18c4b682d1d73
Bug 834961 - pwpb update window modules to ignore private windows

https://github.com/mozilla/addon-sdk/commit/bb69f6051e88b24bb8993c2a5016b91f278efcda
Merge pull request #825 from erikvold/834961-2

Fix Bug 834961 - pwpb update window modules to ignore private windows r=@gozala
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f7200c0f7d14599b5f8ad510ae333663d9d21e94
Bug 834961: fixes for the private-browsing test addon

https://github.com/mozilla/addon-sdk/commit/3c87ada3cb75c13063f126fdc1ad4afc257b91e6
Merge pull request #827 from erikvold/834961-fix

Bug 834961: fixes for the private-browsing test add-on a=@Gozala
Looks like a bunch of private browsing tests are intermittently failing:
TEST-UNEXPECTED-FAIL | tests/test-windows.testWindowIteratorPrivateDefault | false != true
TEST-UNEXPECTED-FAIL | tests/test-window-utils-private-browsing.testSettingActiveWindowIgnoresPrivateWindow | Correct active window [1]
error: private-browsing-supported: fail: Correct active window [1]

Etc.


Timing issues, I guess?
Commits pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/980baf5c64fbc2dd91e192efaf5305e3e44bc2ba
Merge pull request #825 from erikvold/834961-2

Fix Bug 834961 - pwpb update window modules to ignore private windows r=@gozala

(cherry picked from commit bb69f6051e88b24bb8993c2a5016b91f278efcda)

Conflicts:

	lib/sdk/tabs/utils.js
	test/private-browsing/windows.js

https://github.com/mozilla/addon-sdk/commit/960c4f425018ccfb84dfe787e1e9e2346d08fd02
Merge pull request #827 from erikvold/834961-fix

Bug 834961: fixes for the private-browsing test add-on a=@Gozala(cherry picked from commit 3c87ada3cb75c13063f126fdc1ad4afc257b91e6)
Blocks: 852338
No longer blocks: 852338
You need to log in before you can comment on or make changes to this bug.