Closed Bug 835030 Opened 7 years ago Closed 7 years ago

Remove svg.smil.enabled pref

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: longsonr, Assigned: longsonr)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 2 obsolete files)

Time for it to retire.
Attached patch patchSplinter Review
Assignee: nobody → longsonr
Attachment #706769 - Flags: review?(dholbert)
Comment on attachment 706769 [details] [diff] [review]
patch

Looks good to me!
Attachment #706769 - Flags: review?(dholbert) → review+
Status: NEW → ASSIGNED
Keywords: dev-doc-needed
Comment on attachment 706769 [details] [diff] [review]
patch

Review of attachment 706769 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGSVGElement.cpp
@@ +434,2 @@
>    }
> +  // else we're not the outermost <svg> or not bound to a tree, so silently fail

Since this function never throws rv, can you please remove the ErrorResult parameter and the [Throws] annotation in SVGSVGElement.webidl?

@@ +447,5 @@
>  void
>  SVGSVGElement::UnpauseAnimations(ErrorResult& rv)
>  {
> +  if (mTimedDocumentRoot) {
> +    mTimedDocumentRoot->Resume(nsSMILTimeContainer::PAUSE_SCRIPT);

Ditto

@@ +465,5 @@
>  bool
>  SVGSVGElement::AnimationsPaused(ErrorResult& rv)
>  {
> +  nsSMILTimeContainer* root = GetTimedDocumentRoot();
> +  return root && root->IsPausedByType(nsSMILTimeContainer::PAUSE_SCRIPT);

Ditto

@@ +485,5 @@
> +  if (root) {
> +    double fCurrentTimeMs = double(root->GetCurrentTime());
> +    return (float)(fCurrentTimeMs / PR_MSEC_PER_SEC);
> +  } else {
> +    return 0.f;

Ditto

@@ +516,5 @@
> +    //  - Make sure we get an up-to-date paint after this method
> +    //  - re-enable event firing (it got disabled during seeking, and it
> +    //  doesn't get re-enabled until the first sample after the seek -- so
> +    //  let's make that happen now.)
> +    FlushAnimations();

Ditto
Attached patch followup (obsolete) — Splinter Review
Attachment #706905 - Flags: review?(dzbarsky)
Attachment #706905 - Attachment is obsolete: true
Attachment #706905 - Flags: review?(dzbarsky)
Attached patch patch (obsolete) — Splinter Review
Attachment #706906 - Flags: review?(dzbarsky)
Whiteboard: [leave open]
Comment on attachment 706906 [details] [diff] [review]
patch

Thanks! r=me
Attachment #706906 - Flags: review?(dzbarsky) → review+
Comment on attachment 706906 [details] [diff] [review]
patch

Doesn't compile
Attachment #706906 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Changing the signatures is complicated by the nsIDOMSVGVSGElement interface. I think it's going to need to be a follow up.
OK, I'll do it as part of bug 833446
Target Milestone: --- → mozilla21
As there was no mention of svg.smil.enabled in the reference, I only added a note in 
https://developer.mozilla.org/en-US/Firefox/Releases/21#SVG
You need to log in before you can comment on or make changes to this bug.