835088 - mozilla-b2g18_v1_0_0 repo naming breaks assumptions in the hg bundle weekly script.

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Justin Wood (:Callek)]

So, in investigating remaining fruit on the tree of v1.0.0 for b2g18, I saw us failing the bundle download (which is actually turning the tree purple)

On looking in ftp I saw we had mozilla-b2g18-v1-0-0.hg there, which was actually created before the last build (which couldn't find the file).

Looking closer at the log it was looking for:
command: hg unbundle http://ftp.mozilla.org/pub/mozilla.org/firefox/bundles/mozilla-b2g18_v1_0_0.hg

Which indeed matches what the repo url is.

After looking closer I saw that it was indeed the bundle script munging this, and not a human mistake in initial branch bringup:
http://mxr.mozilla.org/build/source/tools/scripts/bundle/hg-bundle.sh#18

To not have to think too hard on this on a weekend, I created a symlink on FTP for now, as the ffxbld user to avoid the purple on builds, and allow new uploads of the bundle script to continue being useful in the short term.

Workaround log is below:


-bash-4.1$ ln -s ./mozilla-b2g18-v1-0-0.hg  ./mozilla-b2g18_v1_0_0.hg
-bash-4.1$ ls -la
total 4934808
drwxr-xr-x 2 ffxbld firefox      4096 Jan 26 15:45 .
drwxr-xr-x 9 ffxbld firefox      4096 Aug  2 09:51 ..
-rw-r--r-- 1 ffxbld firefox 490809733 Jan 26 03:25 elm.hg
-rw-r--r-- 1 ffxbld firefox 476237416 Jan 26 03:18 mozilla-aurora.hg
-rw-r--r-- 1 ffxbld firefox 462293240 Jan 26 03:24 mozilla-b2g18.hg
lrwxrwxrwx 1 ffxbld firefox        25 Jan 26 15:45 mozilla-b2g18_v1_0_0.hg -> ./mozilla-b2g18-v1-0-0.hg
-rw-r--r-- 1 ffxbld firefox 462288078 Jan 26 03:24 mozilla-b2g18-v1-0-0.hg
-rw-r--r-- 1 ffxbld firefox 471161345 Jan 26 03:22 mozilla-beta.hg
-rw-r--r-- 1 ffxbld firefox 478461059 Jan 26 03:24 mozilla-central.hg
-rw-r--r-- 1 ffxbld firefox 349108364 Jan 26 03:20 mozilla-esr10.hg
-rw-r--r-- 1 ffxbld firefox 425092535 Jan 26 03:23 mozilla-esr17.hg
-rw-r--r-- 1 ffxbld firefox 482087437 Jan 26 03:26 mozilla-inbound.hg
-rw-r--r-- 1 ffxbld firefox 464898416 Jan 26 03:24 mozilla-release.hg
-rw-r--r-- 1 ffxbld firefox       129 May  5  2011 README.txt
-rw-r--r-- 1 ffxbld firefox 470925064 Jan 26 03:21 services-central.hg
lrwxrwxrwx 1 ffxbld firefox        18 Sep 21 09:21 try.hg -> mozilla-central.hg
-bash-4.1$ pwd
/pub/mozilla.org/firefox/bundles

Comment 1

[Aki Sasaki (not active)]

Dustin: was there a specific reason you named the bundle this way?

BUNDLE=`echo $BRANCH | tr -c '\n[:alnum:]' '-'`.hg

It doesn't allow for underscores.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I think it was a general safe-name-generation attempt.  At the time, branches didn't have much in the way of funny characters in the name.  There's no reason not to add _ to the allowed class.

Comment 3

[Chris AtLee [:catlee]]

Attachment: allow _ in bundle names

Before:
% echo `echo mozilla-b2g18-v1_0_0 | tr -c '\n[:alnum:]' -`.hg
mozilla-b2g18-v1-0-0.hg

After:
% echo `echo mozilla-b2g18-v1_0_0 | tr -c '\n[:alnum:]_' -`.hg
mozilla-b2g18-v1_0_0.hg

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 708141 [details] [diff] [review]
allow _ in bundle names

well that was easier than I thought :-)

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 708141 [details] [diff] [review]
allow _ in bundle names

http://hg.mozilla.org/build/tools/rev/c0321b194cb9

Does this get pulled automatically?

Comment 6

[Aki Sasaki (not active)]

ftp://ftp.mozilla.org/pub/mozilla.org/firefox/bundles/mozilla-b2g18_v1_0_1.hg