Closed Bug 835091 Opened 8 years ago Closed 8 years ago

Code cleanup in lib/freebl/ecl/ecp_256.c

Categories

(NSS :: Libraries, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(2 files)

Attached patch PatchSplinter Review
The attached patch removes the unnecessary header <stdlib.h>, removes
a block of dead code in #ifdef notdef, and add 'static' to the
internal functions.

Bob, please confirm that you don't need the code inside #ifdef notdef.
(I believe you are the original author of ecp_256.c.)
Attachment #706819 - Flags: superreview?(rrelyea)
Attachment #706819 - Flags: review?(ryan.sleevi)
Attachment #706819 - Flags: review?(ryan.sleevi) → review+
Patch checked in on the NSS trunk (NSS 3.14.4).

Checking in ecp_256.c;
/cvsroot/mozilla/security/nss/lib/freebl/ecl/ecp_256.c,v  <--  ecp_256.c
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: 3.14.3 → 3.14.4
The same cleanup for the other lib/freebl/ecl/ecp_xxx.c files.
Attachment #714579 - Flags: review?(ryan.sleevi)
Attachment #714579 - Flags: review?(ryan.sleevi) → review+
Target Milestone: 3.14.4 → 3.15
Comment on attachment 714579 [details] [diff] [review]
Patch for other ecp_xxx.c files

https://hg.mozilla.org/projects/nss/rev/d8870eaa2c43
Attachment #714579 - Flags: checked-in+
Attachment #706819 - Flags: checked-in+
You need to log in before you can comment on or make changes to this bug.