Closed
Bug 835091
Opened 11 years ago
Closed 11 years ago
Code cleanup in lib/freebl/ecl/ecp_256.c
Categories
(NSS :: Libraries, defect, P2)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.15
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(2 files)
2.06 KB,
patch
|
ryan.sleevi
:
review+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
7.45 KB,
patch
|
ryan.sleevi
:
review+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
The attached patch removes the unnecessary header <stdlib.h>, removes a block of dead code in #ifdef notdef, and add 'static' to the internal functions. Bob, please confirm that you don't need the code inside #ifdef notdef. (I believe you are the original author of ecp_256.c.)
Attachment #706819 -
Flags: superreview?(rrelyea)
Attachment #706819 -
Flags: review?(ryan.sleevi)
Updated•11 years ago
|
Attachment #706819 -
Flags: review?(ryan.sleevi) → review+
Assignee | ||
Comment 1•11 years ago
|
||
Patch checked in on the NSS trunk (NSS 3.14.4). Checking in ecp_256.c; /cvsroot/mozilla/security/nss/lib/freebl/ecl/ecp_256.c,v <-- ecp_256.c new revision: 1.4; previous revision: 1.3 done
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: 3.14.3 → 3.14.4
Assignee | ||
Comment 2•11 years ago
|
||
The same cleanup for the other lib/freebl/ecl/ecp_xxx.c files.
Attachment #714579 -
Flags: review?(ryan.sleevi)
Updated•11 years ago
|
Attachment #714579 -
Flags: review?(ryan.sleevi) → review+
Updated•11 years ago
|
Target Milestone: 3.14.4 → 3.15
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 714579 [details] [diff] [review] Patch for other ecp_xxx.c files https://hg.mozilla.org/projects/nss/rev/d8870eaa2c43
Attachment #714579 -
Flags: checked-in+
Assignee | ||
Updated•11 years ago
|
Attachment #706819 -
Flags: checked-in+
You need to log in
before you can comment on or make changes to this bug.
Description
•